feat: add issuance of anoncreds credentials

animo / siera-desktop

https://siera.animo.id/desktop

8 stars 3 forks source link

feat: add issuance of anoncreds credentials #125

Closed TimoGlastra closed 1 year ago

TimoGlastra commented 1 year ago

Adds issuance of anoncreds credentials. Have been working on this in the plane to IIW ✈️

See video for flow. Left is dev version of Siera Desktop, right one is the last release.

https://user-images.githubusercontent.com/23165168/234006134-9479ac95-c87c-4277-9eae-a0d69bd3b72f.mov

The flow isn't optimal yet, but most of the things will be fixed easily when we update to 0.4.x, mainly:

Allow to use schemaId when creating a cred def not in the wallet (currently issue with seqNo, will be solved)
No way to create new dids. We now create a did on bcovrin:test on agent creation. in the future we can add a did registrar, and allow the user to choose which did to use
Only anoncreds flow supported (JSON-LD can be added in a follow up PR)
Netwrok is hardcoded to Indy (BCovrin Test) in the ui, as that's the only supported network. In 0.4.0 we can extract it based on the issuerId

codecov-commenter commented 1 year ago

Codecov Report

Merging #125 (4a56886) into main (68fedd4) will decrease coverage by 2.28%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   76.74%   74.46%   -2.28%     
==========================================
  Files          11       12       +1     
  Lines          43       47       +4     
  Branches        3        3              
==========================================
+ Hits           33       35       +2     
- Misses         10       12       +2

Impacted Files	Coverage Δ
packages/siera-core/src/utils/did.ts	`33.33% <33.33%> (ø)`
packages/siera-core/src/utils/index.ts	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

janrtvld commented 1 year ago

Some notes on the UI:

Would it be an option to put this in the credentials tab and not in a separate AnonCreds tab? Or are there reasons to have a separate tab for just AnonCreds credentials?
We can also make it so you press credentials in the side navigation, and it folds out to show three subtabs: 'Credentials', 'Schemas', and 'Definitions'.
As you reused a lot of the components i think the styling looks great! Make check if everything looks okay in the light mode as well.

TimoGlastra commented 1 year ago

Action points:

remove jsonld vs anoncreds as only AnonCreds is supported
rename AnonCreds tab to templates

berendsliedrecht commented 1 year ago

@TimoGlastra would it be possible to fix those action points and get this merged? The action points seem rather small so it would be good to just pick those up.

berendsliedrecht commented 1 year ago

@TimoGlastra ^^

TimoGlastra commented 1 year ago

I don't really have time to finish this sadly. :(

feel free to pick it up if you have the time

berendsliedrecht commented 1 year ago

@Tommylans Is this something you might have time for? Otherwise I can also take a look. The changes seem quite trivial.

Tommylans commented 1 year ago