animo / siera-desktop

https://siera.animo.id/desktop
8 stars 3 forks source link

feat: Agent deletion #127

Closed Tommylans closed 1 year ago

Tommylans commented 1 year ago

I couldn't really find if it was possible to actually delete the agent from the computer soooo. This was my solution within the app.

@blu3beri Do you know if this exists and if we should even remove it from the computer.

closes #119

image image image
janrtvld commented 1 year ago

In other products, we use the ellipsis vertically for more options. The dropdown also feels a bit big, which doesn't bother much on the agent screen but here it's almost the size of the agent card. Maybe we can change the padding to make it a bit smaller.

Tommylans commented 1 year ago

Made some changes from your comment :+1:

image

janrtvld commented 1 year ago

I meant smaller more as in less padding, primarily on the vertical sides (i think the padding is evenly on all sides now). It's also common to give it a minimal width (i think the current dropdown also has this) to make it more consistent across the app.

So a bit smaller would be like Github does it;

image
Tommylans commented 1 year ago

Like this?

image image

codecov-commenter commented 1 year ago

Codecov Report

Merging #127 (de3da7c) into main (68fedd4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          11       11           
  Lines          43       43           
  Branches        3        2    -1     
=======================================
  Hits           33       33           
  Misses         10       10           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

janrtvld commented 1 year ago

Can we make this alligned?

image
janrtvld commented 1 year ago

@Tommylans Looks good. Maybe we should make the dropdowns consistent and use the three dots everywhere. The agent screen now has a chevron, and the agent card has the ellipsis. What do you think?

Tommylans commented 1 year ago

image image