search

animo93 / JRest

A Java Rest Client developed on the lines of HttpUrlConnection
MIT License
0 stars 6 forks source link

Bug - Fix the github action maven CI build failure #44

Closed animo93 closed 2 weeks ago

animo93 commented 3 weeks ago

The current github action for maven CI build is failing everytime because of TestHttpRESTApi class which is using a MockServer for testing .

So , need to check how this issue can be fixed

thanhtamB2112004 commented 2 weeks ago

Hello, I am interested in your issue, can you assign this to me if it is still available?

animo93 commented 2 weeks ago

Hello @thanhtamB2112004 ,

I haven't yet researched a solution for this issue . So , can you let me know what solution are you planning to implement for the same

thanhtamB2112004 commented 2 weeks ago

Hello @animo93 , First of all, I am currently an unexperienced student and I am trying to contribute to public projects for studying purposes so if I do anything wrong or unprofessionally, please tell me. About the bug, I tried updating the versions of plugins and remove duplicated dependencies, which are configured in pom.xml. image Also, the CodeQL build process failed to build so I configured it to be built manually and updated some versions of actions processes: image Finally, because the update dependency graph step in maven caused range error so I skip it to test the build process image After all the above updates, I push it to my GitHub repo to test it in GitHub actions and they worked. Please review my answer and provide me some comments. Thank you very much.

animo93 commented 2 weeks ago

Hello @thanhtamB2112004 ,

The updates for pom.xml and maven.yml are ok , but there is no need to make any changes to the codeql-analysis.yml file now .

And regarding the build issue with github actions I am getting the below mentioned error before the dependency graph stage . com.animo.jRest.test.TestHttpRESTApi.testSingleStaticHeaderKey() Time elapsed: 0.536 sec <<< FAILURE! org.mockserver.httpclient.SocketConnectionException: Unable to connect to socket localhost/127.0.0.1:8081 at org.mockserver.httpclient.NettyHttpClient.sendRequest(NettyHttpClient.java:226) at org.mockserver.client.MockServerClient.sendRequest(MockServerClient.java:392) at org.mockserver.client.MockServerClient.sendRequest(MockServerClient.java:428) at org.mockserver.client.MockServerClient.upsert(MockServerClient.java:1493) at org.mockserver.client.ForwardChainExpectation.respond(ForwardChainExpectation.java:84) at com.animo.jRest.test.TestHttpRESTApi.createExpectationForInvalidAuth(TestHttpRESTApi.java:46) at com.animo.jRest.test.TestHttpRESTApi.testSingleStaticHeaderKey(TestHttpRESTApi.java:60) Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:8081 Caused by: java.net.ConnectException: Connection refused at java.base/sun.nio.ch.Net.pollConnect(Native Method) at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682) at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:973) at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:337) at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:334) at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:776) at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at java.base/java.lang.Thread.run(Thread.java:1583)

So , are you sure that your github actions build is running fine after removing the dependency graph step ?

thanhtamB2112004 commented 2 weeks ago
animo93 commented 2 weeks ago

ok @thanhtamB2112004 then please raise a PR , and then let's check . And regarding the codeQL , you can disable the workflow for now

thanhtamB2112004 commented 2 weeks ago

Hi @animo93, I uploaded a PR to fix the issue, please review and provide me acknowledgment if it works well. Again thank you for letting me contribute.