search

anirudh-eka / dashtag

MIT License
7 stars 12 forks source link

Derek | #84 | Compound hashtag support for tweets. Not currently avai… #99

Closed dgliwa closed 9 years ago

dgliwa commented 9 years ago

…lable as part of instagram api.

dgliwa commented 9 years ago

Are you okay with using & if we require the user to put the wrap the entire environment variable in quotes? For example,

HASHTAGS='chicago&tech'

insead of

HASHTAGS=chicago&tech

We could make this nicer as a part of #100 as well.

anirudh-eka commented 9 years ago

hmm, is there a reason why we need to wrap it in quotes?

dgliwa commented 9 years ago

I believe & tells a process to be run in the background, so in order to escape it you have to either wrap it in quotes as done above or like the export "HASHTAGS=this&that"

anirudh-eka commented 9 years ago

I see. Just did some reading on it. How about we use 'and'? After we include #100 it will look like this:

ENV["HASHTAGS"] = "#yolo, #dance, #christmas and #candy, #turtles"
anirudh-eka commented 9 years ago

In light of what we talked about and capture in #101 I don't think the issue with '&' will be a problem as it won't be an env variable. So for now I'm ok with us using a '+'. I'm pulling in the request and thanks for your work!

dgliwa commented 9 years ago

Ah, so twitter bearer token is a method on line 92 of the api_service, so it should be defined.