search

anisc / andors-trail

Automatically exported from code.google.com/p/andors-trail
0 stars 0 forks source link

show combat victory every time #267

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
There is a combat victory screen (or toast message) every time the killed 
monster(s) drops gold or an item.

However there is currently no combat victory screen (or toast message) if 
it/they only give(s) xp and neither drop(s) gold nor an item.

As the box is called "combat victory" or something like this and not "loot 
window" we should show the screen in each case. (also when neither gold nor an 
item was dropped)

Many thought the game was buggy, because they expected the screen but it didn't 
show up.

Original issue reported on code.google.com by SamuelPl...@gmail.com on 2 Nov 2011 at 12:09

GoogleCodeExporter commented 9 years ago 
Added a patch for it.
 - Show Loot Dialog also if only xp has been gained
 - provide additional spaces between parts of the message

The patch also provides a fix for the buggy join of strings like:
<string name="dialog_loot_foundgold">You found %1$d gold. </string>
<string name="dialog_monsterloot_gainedexp">You gained %1$d experience. 
</string>

Looks like Androids xml parser omits the trailing space when joining the 
strings above. Resulting in stings like: "You found 10 gold.You gained 20 
experience." instead of "You found 10 gold.You gained 20 experience.".

Original comment by SamuelPl...@gmail.com on 19 Nov 2011 at 6:00

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry cannot edit post:
...instead of: "You found 10 gold. You gained 20 experience."

Original comment by SamuelPl...@gmail.com on 19 Nov 2011 at 6:01

GoogleCodeExporter commented 9 years ago 
Excellent work once again Samuel

Original comment by sdeva...@gmail.com on 19 Nov 2011 at 11:13