anish / archlinux

ArchLinux AUR
https://aur.archlinux.org/
GNU General Public License v2.0
5 stars 2 forks source link

Suggested changes for pipelight & wine-silverlight AUR #1

Closed slackner closed 10 years ago

slackner commented 10 years ago

WARNING: A lot of the changes have not been tested yet. If you agree that the changes are useful it would be nice to do some testing yourself (= at least confirm once that it still compiles well). More details about the changes are listed below.

Main reason for this patchset: All the different pipelight packages (AUR:pipelight, AUR:pipelight-git, repo:pipelight) and wine packages (AUR:wine-silverlight, AUR:wine-compholio-bin, repo:wine-compholio) make it very difficult for users to mix the versions. Nearly every version uses a different path and has different dependencies. My goal is to "unify" the packages a bit, such that users can use for example use our wine-compholio version combined with pipelight from AUR, or even with pipelight-git if they want to try out new features.

This patchset includes the following changes:

1) wine-silverlight installs some additional symlinks to /opt/wine-compholio/bin/*. This is sufficient for Pipelight, and makes it possible to compile Pipelight with the upstream /opt/wine-compholio/ wine path. Moreover the wine version now provides "wine-compholio".

2) Change pipelight dependency to "wine-compholio".

3) Fix a bug in the wine-silverlight PKGBUILD. The ncurses fix has no effect if the ./configure script is overwritten later by autoreconf.

4) Your pipelight package was still missing some dependencies. Since we got a bug report recently for this issue, and I've already fixed it in our repo, it would be nice if you could fix this, too.

5) Some code in the PKGBUILD script of Pipelight looks outdated. I've cleaned this up a bit. For a detailed list of all the changes take a look at the commit message.

If there is anything else I have to fix before merging, please report back and I'll take a look at it.

Regards, Sebastian