search

anishathalye / dotbot

A tool that bootstraps your dotfiles ⚡️
MIT License
7.04k stars 291 forks source link

add link `prefix: string` option #272

Closed eengstrom closed 3 years ago

eengstrom commented 3 years ago

/fixes #259

Builds on previous commits / PRs (#268 and #271) which were needed to fix implicit some assumptions in the glob patterns and construction of the basename to which to prepend the prefix.

anishathalye commented 3 years ago

This looks good, but I'll wait until #271 is resolved/merged before merging this. Do you think it would be helpful to expand a bit on the documentation in the README for this? Or working this into the full example? I think the main use case for this will be to prepend: '.' along with a glob, right?

eengstrom commented 3 years ago

@anishathalye - I rebased this branch to be independent of all other PRs that I've submitted - it passes the tests, and it has no complications w.r.t python versions, like #271.

Review, and merge, at your discretion.

anishathalye commented 3 years ago

Thank you! One question, just to confirm, was the last * in *files** a stray asterisk (076939da8ee683d3cba791914c227f29c21fe042)?

eengstrom commented 3 years ago

Yup - extra - thanks for the catch.