search

anishathalye / dotbot

A tool that bootstraps your dotfiles ⚡️
MIT License
6.91k stars 288 forks source link

Add an "exit on failure" CLI argument #289

Closed ssbanerje closed 2 years ago

ssbanerje commented 2 years ago

Adds an CLI argument ( -x/--exit-on-failure) to exit dotbot on the first failed directive.

Building on the discussion in #288, this updates the Dispatcher with a self._exit member which can be set to enable this behavior. Can also be used in the proposal to change the defaults directive in a future PR.

anishathalye commented 2 years ago

Thank you for the pull request (and including a test ❤️). I took a quick glance, it looks good overall!

This week is a bit busy for me, so I'm not sure if I'll be able to take a closer look and merge in the next few days, but I should be able to do it by this coming weekend.

ssbanerje commented 2 years ago

Any updates on this landing?

anishathalye commented 2 years ago

Thanks for pinging me, and thanks for your patience. I've been a bit overwhelmed with work recently 😅

PR looks good to me, merged in fb18c9b112b3403cd1a214bbf3be8725feab7140!