anishathalye / dotbot

A tool that bootstraps your dotfiles ⚡️
MIT License
7.04k stars 291 forks source link

Add the possibility of specifying more than one source path ... #301

Open ldorigo opened 2 years ago

ldorigo commented 2 years ago

… in which case the destination is assumed to be a folder in which source paths are linked.

This is to solve #301. The diff on github is borked and shows lots of changes, but the changes are actually quite small:

If you're ok with the approach I'll also edit the documentation. I don't really understand how the tests work, but I'll also try to add a few test cases when I have time to look more into it.

anishathalye commented 2 years ago

Thanks for the PR! I haven't taken a close look at the diff/code yet, but my high level understanding is that this seems to be useful functionality that is backwards-compatible.

I'll take a closer look in a couple days.

If it's effort to get the tests running locally, don't worry about it, I can add a test based on your example in https://github.com/anishathalye/dotbot/issues/300#issuecomment-1059172312.

ldorigo commented 2 years ago

Hey, I haven't had time to work more on this and I'm handing in my master's thesis soon so won't have time to look at it for a while more --- if you want to proceed with adding a couple of tests and closing this issue, please don't wait on me :-)