search

anishathalye / dotbot

A tool that bootstraps your dotfiles ⚡️
MIT License
6.9k stars 287 forks source link

Add generic conditional container plugin. #326

Open gnfzdz opened 1 year ago

gnfzdz commented 1 year ago

See #325 for explanation

Not intended as merge worthy, but just something to help visualize the idea. Let me know if it's worth refining.

kurtmckee commented 1 year ago

This is a great start, @gnfzdz! I'd like to assist on implementing a number of initial condition providers, writing up documentation, and adding unit tests. I can pick this up after #313 is reviewed and merged, as it will dramatically affect how the unit tests are implemented (and will make it possible to test the condition providers across all supported operating systems).

gnfzdz commented 1 year ago

@kurtmckee Thanks for the positive feedback. I can definitely see how this would work better with cross platform support. Thanks for the offer to help?

@anishathalye Have you had a chance to review the proposal? I did release this as a separate plugin, but it would feel a lot cleaner if at least the abstract base Condition was available in the core Dotbot project.