anishathalye / dotbot

A tool that bootstraps your dotfiles ⚡️
MIT License
7.04k stars 291 forks source link

Support Python 3.12 #346

Closed kurtmckee closed 1 year ago

kurtmckee commented 1 year ago

All tests pass under Python 3.12 already, but the test suite was using a shutil.rmtree option, onerror, that Python 3.12 introduced a replacement for (onexc) and simultaneously deprecated.

This is addressed, pytest is now configured to escalate warnings into errors, and the test suite -- and CI -- have been updated to include Python 3.12 in their runs.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (840cd16) 89.13% compared to head (26720b8) 89.14%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ========================================== + Coverage 89.13% 89.14% +0.01% ========================================== Files 33 33 Lines 1620 1622 +2 Branches 306 307 +1 ========================================== + Hits 1444 1446 +2 Misses 124 124 Partials 52 52 ``` | [Files Changed](https://app.codecov.io/gh/anishathalye/dotbot/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Anish+Athalye) | Coverage Δ | | |---|---|---| | [tests/conftest.py](https://app.codecov.io/gh/anishathalye/dotbot/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Anish+Athalye#diff-dGVzdHMvY29uZnRlc3QucHk=) | `92.35% <100.00%> (+0.09%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anishathalye commented 1 year ago

Thank you!