search

anishathalye / lumen

Magic auto brightness based on screen contents 💡
https://anishathalye.com/lumen/
GNU General Public License v3.0
2.29k stars 52 forks source link

Windows port #8

Closed anishathalye closed 5 years ago

anishathalye commented 8 years ago

A couple people have asked about a Windows port, so here's an issue where that can be discussed

oliverguhr commented 8 years ago

Looks like there is a Windows API function to set the brightness. MSDN SetMonitorBrightness

anishathalye commented 8 years ago

I don't have any Windows development experience, so it would be great if there's someone else who wants to build a Windows version.

(it shouldn't be too complicated, you can probably copy-paste most of the core logic from the Mac OS code cause it's basically C code)

Braunson commented 8 years ago

I wonder if this can be done with the Electron framework.

Edit; Yeah I get it, Electron is a hog and not ideal for this.

chris-morgan commented 8 years ago

@Braunson … and watch resource usage skyrocket. This is the sort of thing that should use near enough to no memory—I’m guessing it borrows a screen buffer rather than even needing to allocate enough space for that, so we’re probably talking hundreds of kilobytes only, not dozens or scores of megabytes as it would do with Electron. CPU usage would also be inordinate if you were implementing it via Electron.

There’s a place for things like Electron. This is definitely not it.

AlaaAlShammaa commented 8 years ago

Here's a windows version of the app: https://github.com/AlaaAlShammaa/Luminance

anishathalye commented 8 years ago

@AlaaAlShammaa added it to the list of related projects

AlaaAlShammaa commented 8 years ago

@anishathalye Thank you very much :+1:

anishathalye commented 5 years ago

Closing this issue due to inactivity. If there are any other ports of Lumen that work on Windows, we should add them to the README.