anishathalye / neural-style

Neural style in TensorFlow! 🎨
https://anishathalye.com/an-ai-that-can-mimic-any-artist/
GNU General Public License v3.0
5.54k stars 1.51k forks source link

Added an '--overwrite' flag #122

Closed EmergencyTemporalShift closed 6 years ago

EmergencyTemporalShift commented 6 years ago

I kept accidentally overwriting files, so I added a flag to confirm an overwrite.

EmergencyTemporalShift commented 6 years ago

Sorry, I'm new to this. Do I do something now, or are the requested changes approved separately?

anishathalye commented 6 years ago

Here's the workflow I like to follow:

The next step is to make changes based on the feedback, which you can see by clicking the "view changes" button:

screen shot 2018-06-21 at 12 11 00 am

After you make your changes, you should amend your commit. Finally, you should upload your edited commit. This will require a git push --force, because you're rewriting history.

After that, I'll review it, and if everything looks good, it'll be merged in!

EmergencyTemporalShift commented 6 years ago

Alright, forgot to add the files before amending the first time, but it should be fixed now.

anishathalye commented 6 years ago

Thanks, patch merged!