anishjoshi1999 / CodeCareerNepal-Client

CodeCareer
https://www.codecareer.online
BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

feat(ui): infinite scroll pagination #12

Closed samir-byte closed 8 months ago

samir-byte commented 9 months ago
anishjoshi1999 commented 9 months ago

image image image @samir-byte Could you look into why we are getting duplicate companies, and please check on whether the pagination feature is integrated into the company job listing? else, everything seems to work.

anishjoshi1999 commented 9 months ago

feel free to browse the server code : https://github.com/anishjoshi1999/CodeCareerNepal-Server.git and align the frontend code accordingly

vattevaii commented 9 months ago

this pr and my pr have some conflicts.. @samir-byte @anishjoshi1999. I have added separate jobs page (where we are listing out all jobs from all companies). we would need a separate jobs api. Also we would need to modify our search hook to work with apis rather than internal data

anishjoshi1999 commented 9 months ago

this pr and my pr have some conflicts.. @samir-byte @anishjoshi1999. I have added separate jobs page (where we are listing out all jobs from all companies). we would need a separate jobs api. Also we would need to modify our search hook to work with apis rather than internal data

I have open-sourced the backend; feel free to browse and modify it accordingly. It is pinned to my profile.

samir-byte commented 9 months ago

@vattevaii i am not supposed to rebase with feature branch code. I rebased with main branch and it is okay. Plus i am working according to opened issues.

samir-byte commented 9 months ago

@anishjoshi1999 compnay job listing seems to be filtered in frontend. We can keep frontend pagination but doesnt make much sense as long as we are not fetching company specific data from api. Apart from that duplicate issue has been fixed and updated in this pr