anitaa1990 / Biometric-Auth-Sample

Add Biometric Authentication to any Android app
247 stars 141 forks source link

Not Showing Bio-Metric Dialog on Android P devices #10

Closed parthdesai1208 closed 5 years ago

parthdesai1208 commented 5 years ago

Dialog appeared on Devices which having below Android P version. but not appeared on P devices.

Sammekl commented 5 years ago

Do you encounter this issue on an emulator or physical device? I cannot reproduce this issue. Please check the BiometricCallback methods to see the actual error

parthdesai1208 commented 5 years ago

@Sammekl I faced this issue on my one plus (6T) device. A biometric dialog did not appear.

Sammekl commented 5 years ago

@Sammekl I faced this issue on my one plus (6T) device. A biometric dialog did not appear.

That's weird, I'm using a OnePlus 5T myself on Android Pie, no issues whatsoever. Nothing to see in the logs? Did you debug to see if all the code is called in order to show the dialog?

Edit: Probably related to inscreen fingerprint?

parthdesai1208 commented 5 years ago

@Sammekl here I attach a screenshot of the app. as you can see dialog is missing but rest of the things working perfectly. Screenshot_20190509-125647

zakuby commented 5 years ago

Hi @Sammekl , currently i faced the same issue on OnePlus 6T (Pie), its doesn't show Biometric Dialog (title, subtitle, description, and cancelation button) instead its just show an Image.

photo_2019-05-10 17 01 28

However on other devices(Samsung Galaxy S8) with Android Pie, its show the Biometric Dialog.

photo_2019-05-10 18 25 56

Its is possible to show Dialog V23 and Biometric (Default of OnePlus 6T) at the same time ? I looked up to OVO application its show biometric Oneplus 6T and Dialog V23 at the same time photo_2019-05-10 16 53 34

DhruvaSambrani commented 5 years ago

Look at #5. Seems to be the same issue. It's only a problem with on-screen fingerprint devices. How did you do it @Sammekl?

Sammekl commented 5 years ago

You are right, this is probably an issue at OnePlus's end. I've encountered the same issue on my new OnePlus 7 Pro. It does work on the Samsung S10 with inscreen-fingerprint.

It's not just this library which has issues, it's a bug when using BiometricPrompt on OnePlus. I've already reported this issue to OnePlus last week

Edit: I did a test using the default Android BiometricPrompt implementation and can confirm that this is not a library issue. The same issue occurs with the following code:

BiometricPrompt biometricPrompt = new BiometricPrompt.Builder(getApplicationContext())
                .setTitle("Title")
                .setNegativeButton("Text", this.getMainExecutor(), (dialog, which) -> {

                })
                .setDescription("Description")
                .setSubtitle("Subtitle")
                .build();

biometricPrompt.authenticate(new CancellationSignal(), this.getMainExecutor(), new 
     BiometricPrompt.AuthenticationCallback() {
                @Override
                public void onAuthenticationError(int errorCode, CharSequence errString) {
                    super.onAuthenticationError(errorCode, errString);
                }

                @Override
                public void onAuthenticationHelp(int helpCode, CharSequence helpString) {
                    super.onAuthenticationHelp(helpCode, helpString);
                }

                @Override
                public void onAuthenticationSucceeded(BiometricPrompt.AuthenticationResult result) {
                    super.onAuthenticationSucceeded(result);
                }

                @Override
                public void onAuthenticationFailed() {
                    super.onAuthenticationFailed();
                }
            });
DhruvaSambrani commented 5 years ago

Then close the issue?

Sammekl commented 5 years ago

I am not a contributor to this repo so I can't.

@anitaa1990