Added document section with required Links

anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.

GNU General Public License v3.0

42 stars 78 forks source link

Added document section with required Links #143

Closed StarTrooper08 closed 1 year ago

StarTrooper08 commented 3 years ago

Description

Added document section with required Links

Fixes #71

Type of Change:

Documentation

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

N/A

Checklist:

[ ] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged
[ ] I have written Kotlin Docs whenever is applicable

StarTrooper08 commented 3 years ago

This PR should solve issue no. #71

Aaishpra commented 3 years ago

Can you add the issue number in the PR description after Fixes # so that the PR closes the issue

StarTrooper08 commented 3 years ago

Ok I will do it as soon as possible

StarTrooper08 commented 3 years ago

Done

codesankalp commented 3 years ago

@StarTrooper08 Add Fixes #<issue_number> in PR description and not in the PR title. If you read the description you will see Fixes just add the issue number there.

StarTrooper08 commented 3 years ago

Done ✅

StarTrooper08 commented 3 years ago

@Aaishpra do the changes I have made now is right??

Aaishpra commented 2 years ago

@StarTrooper08 any updates?

StarTrooper08 commented 2 years ago

I m sorry, for the delay.

Aaishpra commented 2 years ago

@codesankalp @isabelcosta have a look here

isabelcosta commented 2 years ago

@StarTrooper08 Can you run prettier, so the lint check passes please?

StarTrooper08 commented 2 years ago

Ok @isabelcosta I'll do it. But how can I do it 😅. Can I get help!

isabelcosta commented 2 years ago

@StarTrooper08 of course you can get help :) I just have to ping other maintainers, because I am not very well versed with frontend 😅 @Aaishpra @codesankalp I took a look at the readme and it does say you can run: npm run lint:fix. Can you do this and push the changes?

codesankalp commented 2 years ago

@StarTrooper08 Rebasing your branch with the current developed branch will also make the lining test pass.

StarTrooper08 commented 2 years ago

isabelcosta commented 2 years ago

@StarTrooper08 are you still working on this? If not, let us know so we can make the ticket available again :)

StarTrooper08 commented 2 years ago

Yes yes I was stucked in some other work.

StarTrooper08 commented 2 years ago

I used the command npm run lint:fix. But still, it's showing 1 failing check.

codesankalp commented 2 years ago

I used the command npm run lint:fix. But still, it's showing 1 failing check.

Have you rebased the branch? After rebasing try to run the command and then push the rebased branch.

StarTrooper08 commented 2 years ago

@isabelcosta @codesankalp please have a look

codesankalp commented 2 years ago

@StarTrooper08 Can you please resolve the merge conflicts?

codesankalp commented 2 years ago

@StarTrooper08 Can you please resolve the merge conflicts?

To do this replace the develop branch package-lock.json file with your local file. Also, I see you haven't rebased the branch (try this):

git remote add upstream git@github.com:anitab-org/anitab-forms-web.git 
git fetch upstream
git rebase upstream/develop
npm install
npm run lint:fix
git push