Closed nellyk closed 2 years ago
@nellyk It looks good π and it works well (I tested it locally), Requested a small change below β¬οΈ Also if you can update
yarn.lock
file then it will be better.
Thank you, i do feel feel that we should instead delete the yarn.lock file since yarn isn't used in the project and it can cause confusion especially since they do the same work as package-lock
Thank you, i do feel feel that we should instead delete the yarn.lock file since yarn isn't used in the project and it can cause confusion especially since they do the same work as package-lock
Let's leave it for now, I will create a separate issue for choosing one lock file.
Let's leave it for now, I will create a separate issue for choosing one lock file.
great, i'll leave it as it is
@Aaishpra @codesankalp @isabelcosta could you please approve the workflow to run
Great work @nellyk ! Thank you for fixing this error ππΎ π
Thank you everyone! Excited to have my PR merged β€οΈ
Description
Currently all builds are failing because of a linting problem that was merged in the main branch. This resolves the issue.
I've raised an issue to create a check that would need to be added whilst committing to prevent the linting errors from getting into the main branch.
Fixes #156
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Running
npm run lint
locally before committing this changesChecklist:
Code/Quality Assurance Only