anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.
GNU General Public License v3.0
42 stars 78 forks source link

fix(linting): fix for linting #157

Closed nellyk closed 2 years ago

nellyk commented 2 years ago

Description

Currently all builds are failing because of a linting problem that was merged in the main branch. This resolves the issue.

I've raised an issue to create a check that would need to be added whilst committing to prevent the linting errors from getting into the main branch.

Fixes #156

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

Running npm run lint locally before committing this changes

Checklist:

Code/Quality Assurance Only

nellyk commented 2 years ago

@nellyk It looks good πŸŽ‰ and it works well (I tested it locally), Requested a small change below ⬇️ Also if you can update yarn.lock file then it will be better.

Thank you, i do feel feel that we should instead delete the yarn.lock file since yarn isn't used in the project and it can cause confusion especially since they do the same work as package-lock

codesankalp commented 2 years ago

Thank you, i do feel feel that we should instead delete the yarn.lock file since yarn isn't used in the project and it can cause confusion especially since they do the same work as package-lock

Let's leave it for now, I will create a separate issue for choosing one lock file.

nellyk commented 2 years ago

Let's leave it for now, I will create a separate issue for choosing one lock file.

great, i'll leave it as it is

nellyk commented 2 years ago

@Aaishpra @codesankalp @isabelcosta could you please approve the workflow to run

isabelcosta commented 2 years ago

Great work @nellyk ! Thank you for fixing this error πŸ™ŒπŸΎ πŸš€

nellyk commented 2 years ago

Thank you everyone! Excited to have my PR merged ❀️