Add medium link to Docusaurs page footer

anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.

GNU General Public License v3.0

42 stars 78 forks source link

Add medium link to Docusaurs page footer #172

Closed ToluAkin closed 2 years ago

ToluAkin commented 2 years ago

Description

Add medium link to Docusaurs page footer

Fixes #171

Type of Change:

Add data object to the file docusaurus.config.js

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Run the code

Checklist:

[ ] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

[ ] My changes generate no new warnings
[ ] New and existing unit tests pass locally with my changes

ToluAkin commented 2 years ago

@isabelcosta

codesankalp commented 2 years ago

@ToluAkin Please update the PR description also.

isabelcosta commented 2 years ago

@ToluAkin I will review ;) Just as FYI, I changed your issue description to have the link to the issue you are solving. Usually, you have to add like Fixes #123 where 123 is the number of the issue. In this way, once this is merged GitHub will close the issue automatically.

ToluAkin commented 2 years ago

@isabelcosta All checks are passing now. Is the PR title okay? Do I need to remove the phrase after the issue number?

isabelcosta commented 2 years ago

@ToluAkin the PR title looks good. I wouldn't add the "Fixes #171" part, since it is already in the issue description. But its fine, as long as the title also indicates what the PR is actually fixing :) So it looks great to me!

ToluAkin commented 2 years ago

@ToluAkin the PR title looks good. I wouldn't add the "Fixes #171" part, since it is already in the issue description. But its fine, as long as the title also indicates what the PR is actually fixing :) So it looks great to me!

Thank you!

ToluAkin commented 2 years ago

Hi @codesankalp , @vj-codes Could you help me check this again if it is good to go? Thanks.

Aaishpra commented 2 years ago

I have also added the Hacktoberfest label here.

ToluAkin commented 2 years ago

I have also added the Hacktoberfest label here.

😃 ..... Thank you! I'm happy to help.

isabelcosta commented 2 years ago

The changes made in this PR were tested locally. Following are the results:

Code review - Done
All possible responses (positive and negative tests) were tested as below:
- Run docusaurus website and see footer
  Screenshot/gif: Expected Result: Medium publication link should appear in the footer of Docusaurus Actual Result: as expected there is a medium link in the community tab

Additional Comments: steps to run this (also following our QA guide)

cd docs
yarn install
yarn start
go to http://localhost:3000/anitab-forms-web/

Status of PR Changed to: Ready to Merge.

isabelcosta commented 2 years ago

@ToluAkin I would suggest you to in the "How Has This Been Tested?" next time to show a screenshot showing you tested the change. That makes for a good pull request description that can help maintainers look for your change :)