Update dependencies in the project

anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.

GNU General Public License v3.0

42 stars 78 forks source link

Update dependencies in the project #178

Closed umair-fayaz closed 2 years ago

umair-fayaz commented 2 years ago

Description

Fixes #177 Updating all the dependencies in the project

Type of Change:

Code

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested locally by doing "npm install" and then using the app in browser

Checklist:

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

[ ] New and existing unit tests pass locally with my changes

Aaishpra commented 2 years ago

Please write the issues number and a small PR description.

umair-fayaz commented 2 years ago

Issue #177. Updated package.json using npm-check-updates

umair-fayaz commented 2 years ago

@umair-fayaz When I tried to test it locally, it gave me this error:

I think you just updated the dependencies but the main issue was to update dependency making sure compatibility of other dependencies.

May I know how you got this error. I tried it locally and it worked fine for me

codesankalp commented 2 years ago

May I know how you got this error. I tried it locally and it worked fine for me

I clone your repo and run command npm install

umair-fayaz commented 2 years ago

May I know how you got this error. I tried it locally and it worked fine for me

I clone your repo and run command npm install

I tried the same once again. Install is happening and the app loads in browser. I am getting 104 vulnerabilities (85 moderate, 18 high, 1 critical) after npm install but the same 110 vulnerabilities (90 moderate, 19 high, 1 critical) is what I was getting after cloning the origional repo.

codesankalp commented 2 years ago

I tried the same once again. Install is happening and the app loads in browser. I am getting 104 vulnerabilities (85 moderate, 18 high, 1 critical) after npm install but the same 110 vulnerabilities (90 moderate, 19 high, 1 critical) is what I was getting after cloning the origional repo.

Which node and npm verison are you using?

umair-fayaz commented 2 years ago

I tried the same once again. Install is happening and the app loads in browser. I am getting 104 vulnerabilities (85 moderate, 18 high, 1 critical) after npm install but the same 110 vulnerabilities (90 moderate, 19 high, 1 critical) is what I was getting after cloning the origional repo.

Which node and npm verison are you using?

I tried the same once again. Install is happening and the app loads in browser. I am getting 104 vulnerabilities (85 moderate, 18 high, 1 critical) after npm install but the same 110 vulnerabilities (90 moderate, 19 high, 1 critical) is what I was getting after cloning the origional repo.

Which node and npm verison are you using?

node v14.17.4, npm 6.14.14

codesankalp commented 2 years ago

@umair-fayaz Update the lock file also.

umair-fayaz commented 2 years ago

@umair-fayaz Update the lock file also.

Done!

codesankalp commented 2 years ago

@umair-fayaz It worked this time, the updated package-lock.json file was needed.

Screenshot:

Can you please make changes to avoid this warning? (Updating your npm may help)

umair-fayaz commented 2 years ago

@umair-fayaz can you please add information about this PR in the description of the PR, as @Aaishpra mentioned?

You can do this like:

Here's our PR template https://github.com/anitab-org/anitab-forms-web/blob/develop/.github/PULL_REQUEST_TEMPLATE.md

done!

isabelcosta commented 2 years ago

@Aaishpra before we label this "hacktoberfest-accepted" it should have 2 approvals right :) Because it would mean it does not require more changes. If you and @codesankalp or any other contributor approves, feel free to add again :)

umair-fayaz commented 2 years ago

Thanks, @umair-fayaz, It looks good to me 👍. The only thing remaining is to remove or update the yarn.lock file. I have asked @Aaishpra about this. After her comment, it will be ready to be merged.

Sure! thanks

Aaishpra commented 2 years ago

Thanks, @umair-fayaz, It looks good to me 👍. The only thing remaining is to remove or update the yarn.lock file. I have asked @Aaishpra about this. After her comment, it will be ready to be merged.

I would prefer updating it instead of removing.

Aaishpra commented 2 years ago

@Aaishpra before we label this "hacktoberfest-accepted" it should have 2 approvals right :) Because it would mean it does not require more changes. If you and @codesankalp or any other contributor approves, feel free to add again :)

Sure Isabel, I added that because there were only small changes required in the PR but as you have mentioned, I think we should go by the rule. Now I will add the label after two approvals 😄

umair-fayaz commented 2 years ago

Thanks, @umair-fayaz, It looks good to me 👍. The only thing remaining is to remove or update the yarn.lock file. I have asked @Aaishpra about this. After her comment, it will be ready to be merged.

I would prefer updating it instead of removing.

But the file is autogenerated. Updating 'package.json' hasn't caused any changes to 'yarn.lock'. How can I update it?

Aaishpra commented 2 years ago

Thanks, @umair-fayaz, It looks good to me 👍. The only thing remaining is to remove or update the yarn.lock file. I have asked @Aaishpra about this. After her comment, it will be ready to be merged.

I would prefer updating it instead of removing.

But the file is autogenerated. Updating 'package.json' hasn't caused any changes to 'yarn.lock'. How can I update it?

I think yarn upgrade will work.