Updated Zulip.js - Githubissues

msaini28r commented 2 years ago

Description

Fixes #72

Type of Change:

Code
Quality Assurance
User Interface
Outreach
Documentation

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged

msaini28r commented 2 years ago

The issue is solved. #72

isabelcosta commented 2 years ago

@msaini0r please edit the pull request description with a description of the changes and how you tested this? This is a good practice for future PRs, whether it's in our community or other projects, and good for documentation purposes 🤗

isabelcosta commented 2 years ago

removed Ready to Merge label as the PR checks are failing cc @Aaishpra

msaini28r commented 2 years ago

@isabelcosta I am not able to find the issue. I would like to worrk on some other issues

Aaishpra commented 2 years ago

@isabelcosta I am not able to find the issue. I would like to worrk on some other issues

Hi @msaini0r only linters and formatters check is failing if you can fix them it would be great Try running npm run lint to fix them Pasting the error log here so you can have a look.


Linters and Formatters
failed 18 hours ago in 58s
Search logs
3s
1s
3s
47s
4s
Run npm run lint

> osp@0.1.0 lint /home/runner/work/anitab-forms-web/anitab-forms-web
> eslint .

/home/runner/work/anitab-forms-web/anitab-forms-web/src/components/Zulip.js
Error:   61:50  error  Insert `(⏎······················`                                                                                                                                                                                                                                             prettier/prettier
Error:   62:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   63:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   64:25  error  Replace `{zulipstat[0].newcomers_message·?·zulipstat[0].newcomers_message` with `··{zulipstat[0].newcomers_message⏎····························?·zulipstat[0].newcomers_message⏎···························`                                                                  prettier/prettier
Error:   65:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   66:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   67:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   68:1   error  Replace `························{zulipstat[0].celebrate_message·?·zulipstat[0].celebrate_message` with `··························{zulipstat[0].celebrate_message⏎····························?·zulipstat[0].celebrate_message⏎···························`                  prettier/prettier
Error:   69:1   error  Replace `······················` with `························`                                                                                                                                                                                                              prettier/prettier
Error:   70:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   71:25  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   72:1   error  Replace `························{zulipstat[0].opportunities_message·?·zulipstat[0].opportunities_message` with `··························{zulipstat[0].opportunities_message⏎····························?·zulipstat[0].opportunities_message⏎···························`  prettier/prettier
Error:   73:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   74:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   75:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   76:25  error  Replace `{zulipstat[0].questions_message·?·zulipstat[0].questions_message` with `··{zulipstat[0].questions_message⏎····························?·zulipstat[0].questions_message⏎···························`                                                                  prettier/prettier
Error:   77:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   78:23  error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   79:1   error  Replace `························` with `··························`                                                                                                                                                                                                          prettier/prettier
Error:   80:1   error  Replace `·······················{zulipstat[0].general_message·?·zulipstat[0].general_message` with `··························{zulipstat[0].general_message⏎····························?·zulipstat[0].general_message⏎···························`                           prettier/prettier
Error:   81:1   error  Insert `··`                                                                                                                                                                                                                                                                   prettier/prettier
Error:   82:1   error  Replace `····················</ul>` with `······················</ul>⏎····················)`                                                                                                                                                                                  prettier/prettier`

msaini28r commented 2 years ago

@Aaishpra already tried npm run lint but it is showing me an error.

anitab-org / anitab-forms-web

Updated Zulip.js #180

Description

Type of Change:

How Has This Been Tested?

Checklist: