search

anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.
GNU General Public License v3.0
42 stars 77 forks source link

Create email comfirmed UI #29

Open abha224 opened 4 years ago

abha224 commented 4 years ago

Description

As a user, after successful registration, my email has to be confirmed. I need to see an email confirmation message in osp once verification is done.

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

4 hrs

m-code12 commented 4 years ago

@abha224 Is this issue still open?

NarimaneHennouni commented 4 years ago

Hi, is this still open?

emmanuelhashy commented 3 years ago

Hi, abha224 I'd like to work on this issue.

vj-codes commented 3 years ago

@emmanuelhashy hey are you still interested to work on this issue?

Rahulm2310 commented 3 years ago

@vj-codes I would like to take up this issue.

aakankshaagr commented 3 years ago

@vj-codes If this issue is available I would like to work on this issue.

emmanuelhashy commented 3 years ago

No

On Tue, 2 Feb 2021, 19:26 aakankshaagr, notifications@github.com wrote:

@vj-codes https://github.com/vj-codes If this issue is available I would like to work on this issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/open-source-programs-web/issues/29#issuecomment-771867360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIM6RNBSNUSSKWKU7JYO2DS5A7WPANCNFSM4N7O543A .

mayburgos commented 3 years ago

@vj-codes If this issue is available I would like to work on this issue.

You were assigned!

emmanuelhashy commented 3 years ago

No

On Mon, 8 Feb 2021, 19:38 May, notifications@github.com wrote:

@vj-codes https://github.com/vj-codes If this issue is available I would like to work on this issue.

You were assigned!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/open-source-programs-web/issues/29#issuecomment-775356082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIM6RLZ5VFTOZ2BLU2PUCLS6AVQXANCNFSM4N7O543A .

subodhk01 commented 3 years ago

Is someone working on this issue? I would love to help

Rahulm2310 commented 3 years ago

@subodhk01 Thanks for showing interest but it is already been assigned to @aakankshaagr . Feel free to look through some other available issues. @mayburgos Can you please remove the Available label as it might be confusing for a contributor. Thanks 🙂

Aaishpra commented 3 years ago

@vj-codes If this issue is available I would like to work on this issue.

What are your updates @aakankshaagr are you still working on this or are you stuck somewhere do you need help? please update us in a maximum of 2 days or this issue will be made available for others

aakankshaagr commented 3 years ago

@Aaishpra I am still working on this issue. I am working for the first time on such issues so it's taking me longer. I am sorry for the delay. I think by this week this issue will be solved. I will surely update my progress after every 2 days.

Aaishpra commented 3 years ago

No problem @aakankshaagr i just wanted to remind you about the issue, it's good that you are still interested in the issue and workinh on it. Let us know if you face any doubts 😉

aakankshaagr commented 3 years ago

@Aaishpra Earlier I forgot to ask before starting working on this issue. I saw that in swagger UI required verification and confirmation messages are present for user registration. Only email confirmation of account verification is absent. So, I have created a template for account verification successfully. So what I have done is correct or not? If not then can anyone help me by explaining this issue?

Aaishpra commented 3 years ago

@Aaishpra Earlier I forgot to ask before starting working on this issue. I saw that in swagger UI required verification and confirmation messages are present for user registration. Only email confirmation of account verification is absent. So, I have created a template for account verification successfully. So what I have done is correct or not? If not then can anyone help me by explaining this issue?

I believe it is correct as the issue mentions only about creation of UI and not about the implementation part, means a template is enough. Can you show us the template here in the comments and everyone here can review it.

aakankshaagr commented 3 years ago

I believe it is correct as the issue mentions only about creation of UI and not about the implementation part, means a template is enough. Can you show us the template here in the comments and everyone here can review it.

Yeah sure @Aaishpra.I have 2 templates in my mind.Other email templates are simple. So below one is the simple email which I thought of

image

Shall I add a tick sign or party-popper image before congratulations at center and even increase text size?

image

Aaishpra commented 3 years ago

@aakankshaagr the project you are working for is open source programs not mentorship system. And i think the last line should be AnitaB.org along with the link to AnitaB website instead of systers open source. And i like the above template better.

Tagging @isabelcosta and @codesankalp so that they can also give their input here.

Aaishpra commented 3 years ago

Now i see you were confused between mentorship system and Open Source Programs since start, as you mentioned about swagger UI in one of your comment.😅

No problem though, just need a little bit tweaks here and there and everything will be fine.

aakankshaagr commented 3 years ago

Now i see you were confused between mentorship system and Open Source Programs since start, as you mentioned about swagger UI in one of your comment.😅

No problem though, just need a little bit tweaks here and there and everything will be fine.

Yeah I was confused between both 😅 thanks @Aaishpra , Now I got it. I will make changes as you have suggested.

aakankshaagr commented 3 years ago

I have made changes, as suggested by @Aaishpra.I, have attached the final drafts of both designs. @isabelcosta @Aaishpra @codesankalp Please review the designs.

Design 1 : image

Design 2: image image

codesankalp commented 3 years ago

@Aaishpra I want to ask that is this issue is related to making a web-page for email confirmed UI to display on frontend or for making an email template that needs to be sent via mail after email is Confirmed? And the draft made by @aakankshaagr looks good but looks like email templates.

Aaishpra commented 3 years ago

@codesankalp the issue description and issue heading seems very confusing now when I see it properly, for example, the issue headline suggests "Create email confirmed UI" which I think means creating an email template, but the issue description contains this line " I need to see an email confirmation message in osp once verification is done." which in my view means creating a design/UI for the webpage in OSP. I am not sure but, @codesankalp do we have a template for the email confirmation in the project, If yes then the issue clearly means the creation of a webpage and if not then the issue suggests of creation of an email template.

Also, this issue is pretty old (open since the last GSoC period)so I am also confused with the requirements and needs for this issue.

aakankshaagr commented 3 years ago

I also had this doubt that @codesankalp has asked. According to the issue description, I think it will be displayed on the OSP after the account is verified. So, I think I have to create a webpage, not an email template.

aakankshaagr commented 3 years ago

Is this webpage okay @Aaishpra @codesankalp @isabelcosta?

image I think I should remove "Welcome to AnitaB.Org" and in place of "To get started" ," For more information " suits better.

codesankalp commented 3 years ago

@Aaishpra There is no email template for the email confirmation. But if we want to send it by email then this issue must be opened in the backend Repo. There is so much confusion in this. Why don't we ask about it to @abha224 and @isabelcosta? They can better explain this.