anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.
GNU General Public License v3.0
42 stars 77 forks source link

Bug: Streamwise messages not showing on zulip stat card to admin #72

Open codesankalp opened 3 years ago

codesankalp commented 3 years ago

Describe the bug

Streamwise messages are not showing on zulip stat to admin because the condition to check streamwise messages is wrong. We need to delete this condition of checking all streamwise messages by checking the message in the newcomer stream, as it is not required. To test the message

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://localhost:8000/admin/osp/userinformation/
  2. Edit one of the admin user-information and insert 345277 in zulip id.
  3. Now go to this http://localhost:3000/ and log in using the credentials of the user which you have edited previously.
  4. Reload the zulip stats and now you can see that streamwise messages do not show up.

Expected behavior

Streamwise messages do not show up when the student has no message in the newcomer stream.

Screenshots

image

Desktop (please complete the following information):

How to solve

To solve this issue remove the condition of checking the stream messages by checking message in newcomer stream. https://github.com/anitab-org/open-source-programs-web/blob/ab18727af5a5e30829e4d07935a218c6d8a02762/src/components/Zulip.js#L39-L51

I have tested by removing it, it is working fine.

Time Required to solve this issue

codesankalp commented 3 years ago

@isabelcosta Can you please add labels to this issue? As It is a beginner issue so a newcomer can solve this issue :relaxed:

isabelcosta commented 3 years ago

thank you @codesankalp for helping triage!

prachinandi commented 3 years ago

@isabelcosta Ma'am if this issue is not assigned can I take it

isabelcosta commented 3 years ago

yes @prachi237 🤗 Will assign it to you!

prachinandi commented 3 years ago

Thanku ma'am😊

codesankalp commented 3 years ago

@prachi237 Any updates on this issue? Do you need any help or suggestion?

prachinandi commented 3 years ago

@prachi237 Any updates on this issue? Do you need any help or suggestion? 😅sorry, for the delay I had exams, I started working on this issue again . Will send the PR asap

codesankalp commented 3 years ago

@prachi237 Is your exams over and can you make a PR on this?

codesankalp commented 3 years ago

Unassigning @prachi237 due to inactivity.

sidharth3000 commented 3 years ago

if this is still available can i take this?

Aaishpra commented 3 years ago

Yess it is assigned you here, Do ask if you have any doubts

sidharth3000 commented 3 years ago

project is not setting up, its giving me error.

Screenshot 2021-05-20 231846
codesankalp commented 3 years ago

Have you setup the backend correctly and is it running?

sidharth3000 commented 3 years ago

yes now its running, i had to bump up several dependencies. Now if i am not wrong i just have to remove this line. is it right?

Screenshot 2021-05-21 172530
vj-codes commented 3 years ago

@sidharth3000 any updates?

isabelcosta commented 2 years ago

@sidharth3000 removed your assignment due to a lack of activity. Feel free to claim again, if you want to work on it

msaini28r commented 2 years ago

@isabelcosta can you assign this issue to me?

isabelcosta commented 2 years ago

@msaini0r , @codesankalp assigned this ticket to you :)

msaini28r commented 2 years ago

@isabelcosta please merge the pull request.

indravijay-bot commented 1 year ago

if this is still available can i take this?

ASP124 commented 1 year ago

Hello @codesankalp, I request you to grant me the access to work on this issue. Regards ASP

AaryaDarisi commented 6 months ago

Hey @codesankalp, @isabelcosta i see that the issue is still open and left since a while and so i want to take this up if it is available but before picking it i wanted to ask if the steps mentioned in the HOW TO SOLVE section of the description is up to date coz i see that @msaini28r had followed it and ran into some issues. I wanted to confirm before starting to not to waste your time. Thank you!

@msaini28r msaini28r mentioned this issue on Oct 15, 2021 https://github.com/anitab-org/anitab-forms-web/pull/180