fix: reload bug fix - Githubissues

anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.

GNU General Public License v3.0

42 stars 77 forks source link

fix: reload bug fix #92

Closed jeeva2812 closed 3 years ago

jeeva2812 commented 3 years ago

Description

Keeping the correct tab active while reloading

Fixes #74

Type of Change:

Code

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

reloadBug

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

[x] My changes generate no new warnings

codesankalp commented 3 years ago

@codesankalp I think submission() under urls.js file should return ${urlBaseFrontend()}submissions and not ${urlBaseFrontend()}submission. What say?

Yes, I was thinking the same @Rahulm2310 .

Rahulm2310 commented 3 years ago

@jeeva2812 submission() in urls.js file should return ${urlBaseFrontend()}submissions and not ${urlBaseFrontend()}submission. The existing changes would not work till this is applied.

jeeva2812 commented 3 years ago

Ok. I will change that. I thought it was a part of the backend repo. Update: Done @Rahulm2310

Rahulm2310 commented 3 years ago

@jeeva2812 Could you please add a GIF of the fix under the How this has been tested section so that it is easy for reviewers to know what this PR is fixing. Thanks

jeeva2812 commented 3 years ago

Sure. I have updated the description of the PR. @codesankalp @Rahulm2310