anitab-org / anitab-forms-web

AnitaB Forms (web), an application to process smaller 4-week or full day programs to contribute to open source projects. Similar to GSoC, Outreachy, or RGSoC. This is the web app.
GNU General Public License v3.0
42 stars 77 forks source link

feat: Integrated Eslint and Prettier #94

Closed jalajcodes closed 3 years ago

jalajcodes commented 3 years ago

Description

Fixes #75

Type of Change:

Code/Quality Assurance Only

Checklist:

Code/Quality Assurance Only

jalajcodes commented 3 years ago

In docs/README.md which is that of docusaurus in the Deployment to surge part the line which mentions about surge there are certain mistakes Tt is used to deploy our spen source should be It is used to deploy our open source could you pls correct that.

Okay so you weren't able to create the review for these lines coz I didn't change them in this PR, I think we can only create a review for the lines changed in the PR

anyways I'll correct it.

codesankalp commented 3 years ago

@jalajcodes Why there are changes in markdown files? Can markdown files be skipped in this?

jalajcodes commented 3 years ago

@jalajcodes Why there are changes in markdown files? Can markdown files be skipped in this?

Yes, they can be ignored. Any particular reason you want to ignore them?

codesankalp commented 3 years ago

Yes, they can be ignored. Any particular reason you want to ignore them?

As code linting is required so I thought markdown files can be skipped.

jalajcodes commented 3 years ago

Yes, they can be ignored. Any particular reason you want to ignore them?

As code linting is required so I thought markdown files can be skipped.

Okay I see....so should I revert markdown files back to their original state?

codesankalp commented 3 years ago

Yes, you can @jalajcodes but wait for @isabelcosta suggestion on this. @isabelcosta Needs your review here.

isabelcosta commented 3 years ago

Up to you all. I noticed though, that improvements on markdown were kind of good. But I know this lint is more related to code. Is it possible to skip markdown @codesankalp

I think there is not harm in leaving it for markdow. But whatever you decide here is fine

codesankalp commented 3 years ago

Ok, let's leave it to the current state, no need to make changes @jalajcodes. I will review it soon.

jalajcodes commented 3 years ago

@jalajcodes please fix the conflicts.

Done!

codesankalp commented 3 years ago

@isabelcosta I think this can be merged now. Can you please review it again?