Open vj-codes opened 4 years ago
@anitab-org/coding-team can anyone take up this issue?
@vj-codes the margins are incorrect
@Sonal240 which ones? I checked with the doc didn't find any
It's not 16...it's 32 in total see the doc. I have not designed a separate component or so, hence I didn't break 32pt margin to 16-16...
@Sonal240 , @nandini45, @vj-codes I would like to work on it.
@saideepesh000 Its on hold right now, we'll get back to you once its confirmed.
@vj-codes did you update the design metrics?
@nandini45 @Sonal240 please check once!
The screenshot is not visible @vj-codes
The screenshot is not visible @vj-codes
It is visible,can you try refreshing? I'm on phone right it's visible on it too
it's not I tried refreshing it as well
on clicking the link it is though...so I don't think it would create an issue...
Can I work on this issue? :)
@saideepesh000 would you like to work on this?Otherwise it'll be assigned to the person next :)
@saideepesh000 would you like to work on this?Otherwise it'll be assigned to the person next :)
@vj-codes , right now I am working on an issue in this repo and also I've raised my PR, so, you can assign it to anyone else, thanks.
Can I work on this issue? :)
Sure assigning you @adithyaakrishna Happy coding!
Thank You! :) @vj-codes
@adithyaakrishna any updates?
@khushishikhu this issue is assigned to someone else may you please look for some other issue thanks π
Hi @nandini45 @Sonal240 , Sorry for not giving updates here, but I'm currently held up with my final year project work, you can assign it to @khushishikhu
ok
@vj-codes @nandini45 May I work on this issue?
Assigning you @pallavithakare28 Happy coding!
@vj-codes Thank you :)
Hey, @vj-codes if @pallavithakare28 somehow couldn't complete the work here . I would like to get assigned to this as i have already worked on a similar kind of issue .π
Hey, @vj-codes if @pallavithakare28 somehow couldn't complete the work here. I would like to get assigned to this as I have already worked on a similar kind of issue.π
@Aaishpra @vj-codes I am working on this issue currently. As I am new to open source and GitHub too, so it is taking the time. I'll try to give my best to solve this issue. And soon will make a PR. It'll be great if you can guide me where I have to start. Thank you :)
@pallavithakare28 sure, take your time but also remember to update your progress after every 3 days and if you come into any errors or doubts you can ask on zulip or here in comments:)
Hey, @vj-codes if @pallavithakare28 somehow couldn't complete the work here. I would like to get assigned to this as I have already worked on a similar kind of issue.π
@Aaishpra @vj-codes I am working on this issue currently. As I am new to open source and GitHub too, so it is taking the time. I'll try to give my best to solve this issue. And soon will make a PR. It'll be great if you can guide me where I have to start. Thank you :)
Yes, ask any question would be more than delighted to help u through this.
@vj-codes @Aaishpra Can you please help me? I am not getting from where I have to start. And from where I have to make changes.
Hey, @pallavithakare28 you can start by making a new folder or a new file inside the src/Components folder. The next part would be to go to the design link (given in the issue description) and download the image and understand all the CSS required for designing this section. After that, you can probably start writing the code in the new file you created, my suggestion would be to have a look at the code for already developed sections before writing your own new code. Hope, this helps.
Hey, @Aaishpra Got it. Thank you for helping me.
@vj-codes I am working on it. I hope you consider it.
@pallavithakare28 there has been no updates from you. if are working then update us with what you have done and the issue you are facing to complete it?
@nandini45 well if this issue gets available for reassignment i am more than happy to work on it.
@nandini45 Sorry for delay, but I am busy with exam so can't make PR now. It's ok for me if someone wants to work on this issue. Sorry for the inconvenience.
Is it available, can I take this up?
Yes @Harshita-Kanal you can take this up. Let us know if you need any help.
@Harshita-Kanal are you working on it.? if yes please mention the updates
Please assign me this if no update comes from @Harshita-Kanal in a few days.
Hello, sorry for not giving updates here, I had my exams so couldn't complete. You can unassign me and I am very sorry for the delay and inconvenience
@Harshita-Kanal If you're still interested, I think we'll be happy to wait for you :)
@tichnas here... do give us the updates of your work after 3 4 days.. if any issue or doubts feel free to ping us hereπ
@nandini45 Till now I've designed this much: Please let me know any improvements. Also, are the icons acting as a link to Medium, Zulip and Github?
Yes they are the links to the community channels..
On 25 Nov 2020 4:46 p.m., "Sanchit Arora" notifications@github.com wrote:
@nandini45 https://github.com/nandini45 Till now I've designed this much: [image: image] https://user-images.githubusercontent.com/56799401/100220457-68a3ae00-2f3d-11eb-87b8-cc70a5123ab4.png Please let me know any improvements. Also, are the icons acting as a link to Medium, Zulip and Github?
β You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/anitab-org.github.io/issues/109#issuecomment-733643878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOZMDIN32TKZYCVB3SJTOVLSRTRRTANCNFSM4PH6EX7A .
It looks great Just one thing can u check the right side alignments??
If you think 32 it a bit too much space make it 16 both sides.
I am taking about these alignments
@nandini45 @tichnas I wanna give small advice regarding the homepage design. The current state of the homepage is full with texts only, that looks bulky.
Keep the page minimalistic and free of clutter. In someplace instead of text, you can use more images and icons to present your thought.
βReadabilityβ measures how easy it is for people to recognize words, sentences, and phrases.
Create one contrasting landing page, that will change the entire look.
I hope my advice will be helpful for you guys to design the beautiful homepage.π
@nandini45 @vj-codes What changes do you suggest considering @purnima143's advice?
@tichnas apology for the late reply As far as her advice is considered I agreed her points are perhaps correct but right now i can't ask u to redesign it again.. there are many features which we will need to work on. I will say do what was initially said , if u can make minimal changes without affecting the proposed design.. well and good..make changes but dont change the layouts
Is your feature request related to a problem? Please describe.
As a developer, I need the following section to be developed so that I can add is as a Home component here
Mocks
Develop this section only
overall margin: 32pt In between each section: 32pt distance between image and text: 32pt distance from horizontal line: 32pt Avenir Body light 18pt Heading 24pt Text Color:#103B81 Design link for development
Acceptance Criteria
Update [Required]
Definition of Done
Estimation
6-8 hours