search

anitab-org / anitab-org.github.io

AnitaB.org Open Source website has information about our community, including our open source projects, participation in programs, events, and a few contribution guidelines.
https://anitab-org.github.io
GNU General Public License v3.0
149 stars 190 forks source link

Coding: Develop the following section for Home Page #110

Open vj-codes opened 4 years ago

vj-codes commented 4 years ago

Is your feature request related to a problem? Please describe.

As a developer, I need the following section to be developed so that I can add is as a Home component here

Mocks

Develop this section only

Screenshot (32)_LI

overall margin: 32pt Margin top for GETTING STARTED heading: 64pt In between each section: 32pt distance between image and text: 32pt distance from horizontal line: 32pt Avenir Body light 18pt Heading 24pt Text Color:#103B81

Design link for development

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

6-8 hours

nandini45 commented 4 years ago

@anitab-org/coding-team can anyone take up this issue?

Sonal240 commented 4 years ago

@vj-codes the margins are incorrect

vj-codes commented 4 years ago

@Sonal240 which ones? I checked in the doc didn't find any

Sonal240 commented 4 years ago

overall margin: 32pt Margin top for GETTING STARTED heading: 64pt In between each section: 32pt distance between image and text: 32pt distance from horizontal line: 32pt Avenir Body light 18pt Heading 24pt Text Color:#103B81

vj-codes commented 4 years ago

@Sonal240 I see a mess has been sent on zulip to , will change accordingly.BTW the metrics say body is still 14 pt , when was it changed to 18pt?

Sonal240 commented 4 years ago

Well I remember last time when Anna had introduced the doc she mentioned this...also note that if body is 14pt then how can View More be 16pt? Body should be given more emphasis than view more right?

nandini45 commented 4 years ago

@vj-codes complete and update the labelling please there are contributors looking for new issues . if you can update this issue and other one we can make it available as soon as possible

vj-codes commented 4 years ago

@Sonal240 @nandini45 check once please!

Sonal240 commented 4 years ago

LGTM @vj-codes !!

raksh543 commented 4 years ago

I am willing to work on this.

raksh543 commented 4 years ago

Will you be providing the four images as present in design or can i use any sample image?

Sonal240 commented 4 years ago

Give me 10 min I'll share link for development

Sonal240 commented 4 years ago

https://xd.adobe.com/view/09a9fdf0-a193-4b3f-47c2-216055c7ca42-7f98/ is it working? are you able to download it?

raksh543 commented 4 years ago

Yes now its working, i am able to download

raksh543 commented 4 years ago

I also wanted to ask that what are the dimensions of the image to be displayed?

Sonal240 commented 4 years ago

kindly click on the image and see the properties

raksh543 commented 4 years ago

screencapture-localhost-3000-2020-08-25-20_53_39 Update of work: This is the screen shot of things that have been implemented. Work left: Responsiveness and final checking the margins.

raksh543 commented 4 years ago

Screenshot (149) The Ways to contribute section looks like this. It got overlapped in the previous screenshot.

tichnas commented 3 years ago

@raksh543 Are you working on the changes requested in the PR?

Aaishpra commented 3 years ago

@nandini45 @Sonal240 I don't see updates from the current assignee for the requested changes in the PR . So, can i work on this?

Sonal240 commented 3 years ago

Let's wait for 1 or 2 days @raksh543 May you please work on the changes requested else this issue would be assigned to @Aaishpra

raksh543 commented 3 years ago

@Sonal240 I would continue to work on this. Pr for this issue have already been made. There are some minor fixes needed, so i would complete that.

Sonal240 commented 3 years ago

Kindly complete them asap @raksh543

tichnas commented 3 years ago

@raksh543 Are you working on the changes? If not, can I please work on it @Sonal240? Thanks

tichnas commented 3 years ago

@nandini45 I think this work is already done. Can you please confirm?

nandini45 commented 3 years ago

@tichnas yes the work is done. You can see it in this PR

134

tichnas commented 3 years ago

@nandini45 No, I think the work is already merged as it's visible to me and we no longer require that PR (or this issue).

This is the work visible to me: image

shades-7 commented 3 years ago

@nandini45 hey is this issue still open, can I work on this?

shades-7 commented 3 years ago

@nandini45 hey is this issue still open, can I work on this?

nandini45 commented 3 years ago

@shades-7 i dont know the current status of the issue. i will get back to you and i think you have a issue already in hand complete that after that i can assign you this one.

nawed2611 commented 2 years ago

Hi! Is this issue still open? I would like to work on it.

preeti13456 commented 2 years ago

This issue must be closed since all the asked sections were already merged