[Chore] Update GitHub actions - Githubissues

anitab-org / bridge-in-tech-backend

BridgeInTech (BIT) is an application that allows organizations, mentors and mentees to actively collaborate through mentoring programs. This is the backend client of BridgeInTech.

https://bridgeintech-bit-heroku-psql.herokuapp.com/

GNU General Public License v3.0

24 stars 80 forks source link

[Chore] Update GitHub actions #263

Closed y-martinez closed 3 years ago

y-martinez commented 3 years ago

Description

This PR adds:

Update the main.yml with the health check of the postgresql container, avoiding problems with running tests in the workflow

Fixes #262

Type of Change:

Quality Assurance

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

[X] My PR follows the style guidelines of this project
[X] I have performed a self-review of my own code or materials
[X] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[X] Any dependent changes have been merged

Code/Quality Assurance Only

[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

epicadk commented 3 years ago

@y-martinez I think this is good enough. Did you have some other changes in mind? If not please mark it as ready for review.

y-martinez commented 3 years ago

@y-martinez I think this is good enough. Did you have some other changes in mind? If not please mark it as ready for review.

Yes, I am testing, but yes I marked it as ready for review :)