refactor : add typehints to program module

anitab-org / bridge-in-tech-backend

BridgeInTech (BIT) is an application that allows organizations, mentors and mentees to actively collaborate through mentoring programs. This is the backend client of BridgeInTech.

https://bridgeintech-bit-heroku-psql.herokuapp.com/

GNU General Public License v3.0

24 stars 80 forks source link

refactor : add typehints to program module #283

Closed Anmollenka closed 3 years ago

Anmollenka commented 3 years ago

Description

Added typehints to the program modules

Fixes #247

Type of Change:

Code

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged

Code/Quality Assurance Only

[ ] My changes generate no new warnings
[ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been published in downstream modules

welcome[bot] commented 3 years ago

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

Anmollenka commented 3 years ago

@vj-codes Can you please review this.

Anmollenka commented 3 years ago

@mtreacy002 My bad while adding a new import statement it got pasted.

Anmollenka commented 3 years ago

Will make the required changes.

Anmollenka commented 3 years ago

@mtreacy002 Could you check if the lint workflow are failing again?

isabelcosta commented 3 years ago

@mtreacy002 I approved it, do you think this is a "ready to merge"? I think it could be, if tests pass, this does not affect the program in runtime. i know you are a little unavailable, so I'll merge :)

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! 🎉🎉🎉 We here at AnitaB.org are proud of you!

mtreacy002 commented 3 years ago

Thank you @isabelcosta . Sorry about the delay in response 😊