search

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
167 stars 378 forks source link

Feature : Use moshi instead of Gson #1041

Open epicadk opened 3 years ago

epicadk commented 3 years ago

Is your feature request related to a problem? Please describe.

Currently we use GSON for serializing data.

Describe the solution you'd like

Upgrade to Moshi.

Additional context

Bench Mark tests

SO answer

Blog post I found useful

epicadk commented 3 years ago

I'd like to work on this.

vj-codes commented 3 years ago

@epicadk would you still like to work ?

epicadk commented 3 years ago

@epicadk would you still like to work ?

Yes

vj-codes commented 3 years ago

Assigning you @epicadk Happy coding!

epicadk commented 3 years ago

There are some issue with the current gradle version. Done with the coding part of it. I'll open a pr soon. I have tests hence the delay.

epicadk commented 3 years ago

I can't seem to find a solution to the problem. Can you mark this as help wanted? @vj-codes

epicadk commented 3 years ago

meanwhile , can I work on other issues ? @vj-codes

epicadk commented 3 years ago

@vj-codes you can remove the help wanted tag now .