search

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
164 stars 379 forks source link

Feature : Shift to ViewBinding #1047

Open epicadk opened 3 years ago

epicadk commented 3 years ago

Is your feature request related to a problem? Please describe.

Kotlin Synthetic is deprecated .

Describe the solution you'd like

The app uses kotlin synthetics at a number of places but it's now deprecated by google. Kotlin doesn't support synthetic so a new approach has been provided by google i.e using the view binding or data binding. View binding is comparatively lighter for rendering UIs as compared to the data binding. So we can use view binding instead of kotlin synthetics. ( Thanks @abhinav78910)

Additional context

https://developer.android.com/topic/libraries/view-binding/migration

abhinav12k commented 3 years ago

Hi @epicadk, I would like to work over this issue

epicadk commented 3 years ago

You'll have to wait for the issue to get approved before you can start working on it. Try asking on zulip.

abhinav12k commented 3 years ago

Hey @epicadk can you add a description to this issue. The app uses kotlin synthetics at a number of places but it's now deprecated by google. Kotlin doesn't support synthetic so a new approach has been provided by google i.e using the view binding or data binding. View binding is comparatively lighter for rendering UIs as compared to the data binding. So we can use view binding instead of kotlin synthetics.

vj-codes commented 3 years ago

@abhinav78910 hey thanks for providing a detailed description ,once it's updated on the issue it'll be approved and assigned to you .

annabauza commented 3 years ago

Approved

vj-codes commented 3 years ago

Assigning you @abhinav78910 Happy coding!

epicadk commented 3 years ago

Status on hold cc @annabauza

devptyagi commented 3 years ago

Is it still available? If yes, I'd like to work on it. @epicadk @isabelcosta @annabauza

epicadk commented 3 years ago

Is it still available? If yes, I'd like to work on it. @epicadk @isabelcosta @annabauza

Sure.