anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
165 stars 380 forks source link

Resend Email feature while Registering #105

Open mohak1283 opened 6 years ago

mohak1283 commented 6 years ago

Description

As a user, I need to have resend email feature in the Android app, so that I can register in the Android app.

Sometimes, when the user is signing up in the Android app, the verification email does not comes. So, the Android app should have resend email feature so that verification email is sent again.

Mock

resendemailmock

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

5 hours

Would you like to work on this issue?

mohak1283 commented 6 years ago

Can I work on this issue? @isabelcosta

isabelcosta commented 6 years ago

@mohak1283 you tend to do a mix of templates, not following one or another :O

I'm curious, you keep putting this... do you think this is needed in the template? You can suggest incorporating this to the templates, to the community in an open session if you want.

### Would you like to work on this issue?
- [x] Yes
- [ ] No
mohak1283 commented 6 years ago

Sorry for this @isabelcosta should I remove it now?

isabelcosta commented 6 years ago

@mohak1283 no need to be sorry. I left it there, what I'm asking is if you think this is relevant for the issue. If you think it is you can suggest to the community in a Community Open Session. I already edited the description and left it there, it does no harm.

On another topic, did you see what @m-murad mentioned here on Slack it sounds a great idea. What do you think of it?

mohak1283 commented 6 years ago

Okay I will suggest this in Community Open Session :+1: And regarding @m-murad idea, Yes it sounds like a great idea will implement this :+1:

isabelcosta commented 6 years ago

Ok, I'm not sure how this will be done, because I see snack bar disappearing right away, but maybe it can show up longer. If you decide to do it like that, can you update your acceptance criteria or the description to reflect what you want to do @mohak1283 ?

isabelcosta commented 6 years ago

Also, try to work on an issue at a time ;) you already have to in the pipeline, there is no rush in this ;) @mohak1283

mohak1283 commented 6 years ago

Okay @isabelcosta will keep in mind :+1: Actually we can specify little longer to display snackbar, But it will be not that much longer. Yes you are right that it will be disappeared right away So what do you think where to keep resend email option? @isabelcosta .

isabelcosta commented 6 years ago

@mohak1283 right now I have no idea :P Maybe you can think a bit more on this and @m-murad can suggest something ;)

mohak1283 commented 6 years ago

Okay will try to include this option where appropriate @isabelcosta :+1:

mohak1283 commented 6 years ago

@isabelcosta I have added the mockup of Resend Email option. What do you think? Should I place it here only or somewhere else?

isabelcosta commented 6 years ago

@mohak1283 Maybe below sign up button? Then when clicking there, the app could open a dialog or a screen to type the email?

CC @m-murad

mohak1283 commented 6 years ago

Yeah, This would be a great idea @isabelcosta :+1: Will implement this :+1:

isabelcosta commented 6 years ago

@mohak1283 this is not exactly what @m-murad suggested, so I'm not sure if he has something to say about this approach. You can start working on it, but I guess you can also wait, not sure...

m-murad commented 6 years ago

The button should say "Resend email" and should be on the snack bar which says email not verified

m-murad commented 6 years ago

We can make the snackbar appear for longer (maybe indefinitely until dismissed).

isabelcosta commented 6 years ago

Ok @m-murad so to make clear the idea is to: when the user registers and then tries to login, but hasn't verified the email, when it shows the snackbar showing that something went wrong (if resend email), then in the snackbar it shows a button?

Priyansh-Kedia commented 4 years ago

Is this issue still open? May I work on this?

aditmehta9 commented 4 years ago

@Priyansh-Kedia do you still want to work on this issue I hadn't assigned this issue to you at that time because you were working on multiple issues.

somayaj commented 4 years ago

Can i work this issue? Can it be assigned to me? Thanks.

somayaj commented 4 years ago

All, can someone assign this to me? Willing to contribute.

aditmehta9 commented 4 years ago

All, can someone assign this to me? Willing to contribute.

Please read the above conversation before contributing.

somayaj commented 4 years ago

the conversation seems outdated, but thanks.

On Wed, Nov 11, 2020 at 11:02 AM Adit Mehta notifications@github.com wrote:

All, can someone assign this to me? Willing to contribute.

Please read the above conversation before contributing.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/anitab-org/mentorship-android/issues/105#issuecomment-725540884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRAZGKQ4D7G5VHVW6JH6T3SPK7SLANCNFSM4GFAUK4A .