Docs : Why use MVVM architecture missing

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.

https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk

GNU General Public License v3.0

165 stars 379 forks source link

Docs : Why use MVVM architecture missing #1080

Open Sanika1999 opened 3 years ago

Sanika1999 commented 3 years ago

Describe the bug The why use MVVM architecture is missing in the documentation.

To Reproduce

Steps to reproduce the behavior:

Go to https://github.com/anitab-org/mentorship-android/wiki/Tech-Stack
Scroll down to Why use MVVM architecture?

Screenshots

Additional context It will be useful to have this info for new contributors and for understanding the app.

haran2248 commented 3 years ago

I am not able to clone the wiki locally.Is there any way to do this?Can you guide me?

Sanika1999 commented 3 years ago

Hi @haran2248 I guess you can clone it to your local machine using git clone https://github.com/anitab-org/mentorship-android.wiki.git

Sanika1999 commented 3 years ago

This is where I found it just scroll down on the page

haran2248 commented 3 years ago

Cool I work on this Thanks @Sanika1999

Sanika1999 commented 3 years ago

@haran2248 You have to be assigned this issue first try asking on zulip and someone will assign it to you

epicadk commented 3 years ago

@haran2248 Welcome to the community. Do you still want to work on this?

haran2248 commented 3 years ago

Hey @epicadk Ill try to work on it.If you want you can also try to come up with a fix

epicadk commented 3 years ago

Hey @epicadk Ill try to work on it.If you want you can also try to come up with a fix

assigning you. Happy Documenting :).

vj-codes commented 3 years ago

@haran2248 any updates ?

vj-codes commented 3 years ago

Unassigning @haran2248 due to inactivity.

ravi5175 commented 3 years ago

Can i work on this issue??

devkapilbansal commented 3 years ago

@ravi5175 this issue is marked as 'first-timers-only'. Since you already opened a PR on this repository you can't work on this issue. Please look for other issues

kartikraj commented 3 years ago

Hi @epicadk, i would like to work on this .

kartikraj commented 3 years ago

@epicadk , I am trying to push but it shows access denied . I guess you need to add me as collaborator for wiki.

devkapilbansal commented 3 years ago

Hi @kartikraj you need to fork the repository and do changes in your forked copy. After that open a PR. You are not supposed to make changes here.

kartikraj commented 3 years ago

@devkapilbansal Actually , i did but i couldnt see wiki files in my forked repo. Then on searching i got to know that wiki files cannot be forked, only collaborators of wiki have the permission by default & to update wiki we need to push changes directly .

devkapilbansal commented 3 years ago

Ohh ohkay, then please create a document and share it's link or a markdown file in the PR instead.

kartikraj commented 3 years ago

Tech-Stack.md This is the file i have updated in wiki .

kartikraj commented 3 years ago

You can also change permission for wikis for time being so i can push becuz this has to do nothing with main repo.link

vj-codes commented 3 years ago

@kartikraj hey can you try and clone the wiki locally by this link and see if it works? https://github.com/anitab-org/mentorship-android.wiki.git

kartikraj commented 3 years ago

@vj-codes Yes I have cloned the same and made changes, but it asks for persmission to push. You can change permission for wiki which is restricted. This may help :changing access permission for wikis

devkapilbansal commented 3 years ago

Nvm, we are going to soon move documentation to gh-pages. Then these problem will not happen. @kartikraj it is not possible to give permissions as collaborators.

epicadk commented 3 years ago

@vj-codes Yes I have cloned the same and made changes, but it asks for persmission to push. You can change permission for wiki which is restricted. This may help :changing access permission for wikis

Even we aren't allowed to edit the WIKI 😅

kartikraj commented 3 years ago

oh okay.

vj-codes commented 3 years ago

@kartikraj any update about this? You can create a .md file and commit the changes instead

kartikraj commented 3 years ago

@kartikraj any update about this? You can create a .md file and commit the changes instead

Okay. Only the Tech stack document right?

kartikraj commented 3 years ago

i have created PR please check @vj-codes

devkapilbansal commented 3 years ago

@kartikraj why not any PR is linked to this issue?

kartikraj commented 3 years ago

@kartikraj why not any PR is linked to this issue?

oh sry, done now