search

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
165 stars 379 forks source link

Realign "Add Task" Floating Action Button on Relation TASKS Tab #1131

Closed ravi5175 closed 3 years ago

ravi5175 commented 3 years ago

Describe the bug

"Add Task" FAB(Floating Action Button) is used to add task by the Mentor for the Mentee in Mentorship-Android Application, currently, Task tab need to scrolled to access Add Task FAB.

To Reproduce

Steps to reproduce the behavior:

  1. Login Mentorship-Android App
  2. Select Relation
  3. Select Task Tab
  4. Scroll down to access Add Task FAB

Expected behavior

"Add Task" FAB is expected to be aligned at the Bottom Right corner of Task Tab and should not scroll with the Tab.

Screenshots

FAB-issue

epicadk commented 3 years ago

Would you like to work on this?

epicadk commented 3 years ago

Also since @vj-codes is looking after the design, do you approve?

ravi5175 commented 3 years ago

@epicadk i will like to work on this issue

vj-codes commented 3 years ago

@ravi5175 nice catch and thank you for creating the issue although this was supposed to be fixed by #745 it still exists Assigning you, Happy coding!

ravi5175 commented 3 years ago

@vj-codes @epicadk there had been some slight miscalculations for this issue, at first Task Tab Layout is using a Relative Layout, placing the Add Task button at the bottom, it seems like the fault was at this point but it is due to the app bar layout in main activity layout. App Bar Layout is actually causing the Nested Sroll View to scroll itself while expanding or collapsing. Since, Nested Scroll View is the parent container for the Fragment Frame Layouts, it appears like the fragments are scrolling normally but in actual nested scroll view scrolls first and then fragments starts to scroll. I tried several tweaks, tried to search solutions on to the web but it seems like there is none at this point of time.

Though we can still make it work by 1 - Disabling the App Bar Layout in Collapsed state while Relation Fragment is active 2 - Remove "Add Task" as a FAB and adding it to somewhere else where a fixed position is not required.

isabelcosta commented 3 years ago

Thank you for working on fixing this! As we discussed on the Mentorship System call, I'll close this since we are about to change this UI soon 🤗 cc @ravi5175 @epicadk