Closed Ankit-akumar closed 3 years ago
Looks good. Thankyou. Needs @isabelcosta 's approval to run workflows.
@isabelcosta can you please approve request to run the workflow?
@Ankit-akumar I noticed in your PR description, the way you linked the issue was not a way that would make GitHub close the issue once this one got merged. So I changed from:
**Fixes** # [[ISSUE](https://github.com/anitab-org/mentorship-android/issues/1137)]
to
Fixes #1137
and this way, github will know which issue on the platform you are referring to :)
Description
A complete discussion over this can be found here. Current Behaviour: Simply shows a toast to the user saying "Invalid XYZ". Changed Behaviour: Gives a detailed error message for any invalid input. Following screenshots would be helpful ->
Fixes #1137
Changed the validateDetails method of SignUpActivity.kt for setting the appropriate error message to be displayed to the user. Added the messages in strings.xml. (And rearranged some lines of code unintentionally :-) )
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Steps to reproduce -> 1) Start the app. 2) Navigate to Signup activity by clicking the SignUp button. 3) Enter the following strings as test cases or create your own.
Checklist:
Code/Quality Assurance Only