search

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
167 stars 379 forks source link

Fix #1141 : Removed error icons from password so that visibility toggle is clickable #1143

Closed Acash512 closed 2 years ago

Acash512 commented 3 years ago

Description

Resolved the bug that caused overlapping of error icon with visibility toggle in password editTexts for SignUpActivity

Fixes #1141

Before

During Runtime After SignUp is clicked

Now

During Runtime After SignUp is clicked

Type of Change:

Code/Quality Assurance Only

Checklist:

Code/Quality Assurance Only

epicadk commented 3 years ago

Please post a screen shot of the changes

Acash512 commented 3 years ago

Please post a screen shot of the changes

Done

@epicadk I also noticed just now that we have checked the format of email, only during runtime, and not when signup button is clicked, earlier since the error was set on tiEmail.editText, it was retained even when Sign Up button was clicked, but now it isn't as I have the set the error on tiEmail during runtime(which is set null in validateDetails funcn invoked when Sign Up is clicked as email is not blank and it's format is not checked there) so that UI looks similar.

So shall I set the the error on tiEmail.editText as before during runtime or check if the email has correct format or not when the Sign Up button is clicked too and set the error accordingly.

Please take a look into this too, I will accordingly update the PR as per your suggestion, sorry for bothering you with this now, I should have noticed that earlier.

epicadk commented 3 years ago

@isabelcosta please approve pr run.

Please post a screen shot of the changes

Done

@epicadk I also noticed just now that we have checked the format of email, only during runtime, and not when signup button is clicked, earlier since the error was set on tiEmail.editText, it was retained even when Sign Up button was clicked, but now it isn't as I have the set the error on tiEmail during runtime(which is set null in validateDetails funcn invoked when Sign Up is clicked as email is not blank and it's format is not checked there) so that UI looks similar.

So shall I set the the error on tiEmail.editText as before during runtime or check if the email has correct format or not when the Sign Up button is clicked too and set the error accordingly.

Please take a look into this too, I will accordingly update the PR as per your suggestion, sorry for bothering you with this now, I should have noticed that earlier.

Sure you can check the it on the signup click event.

epicadk commented 3 years ago

@isabelcosta please approve pr run.

Acash512 commented 3 years ago

@isabelcosta please approve pr run.

Please post a screen shot of the changes

Done @epicadk I also noticed just now that we have checked the format of email, only during runtime, and not when signup button is clicked, earlier since the error was set on tiEmail.editText, it was retained even when Sign Up button was clicked, but now it isn't as I have the set the error on tiEmail during runtime(which is set null in validateDetails funcn invoked when Sign Up is clicked as email is not blank and it's format is not checked there) so that UI looks similar. So shall I set the the error on tiEmail.editText as before during runtime or check if the email has correct format or not when the Sign Up button is clicked too and set the error accordingly. Please take a look into this too, I will accordingly update the PR as per your suggestion, sorry for bothering you with this now, I should have noticed that earlier.

Sure you can check the it on the signup click event.

@isabelcosta please approve pr run.

Please post a screen shot of the changes

Done @epicadk I also noticed just now that we have checked the format of email, only during runtime, and not when signup button is clicked, earlier since the error was set on tiEmail.editText, it was retained even when Sign Up button was clicked, but now it isn't as I have the set the error on tiEmail during runtime(which is set null in validateDetails funcn invoked when Sign Up is clicked as email is not blank and it's format is not checked there) so that UI looks similar. So shall I set the the error on tiEmail.editText as before during runtime or check if the email has correct format or not when the Sign Up button is clicked too and set the error accordingly. Please take a look into this too, I will accordingly update the PR as per your suggestion, sorry for bothering you with this now, I should have noticed that earlier.

Sure you can check the it on the signup click event.

@epicadk I have made changes accordingly please review, I have set error on email for incorrect format even when sign up is clicked, and other changes that I have added in the third commit were to make sure that the error is set null during runtime when the input becomes valid, as far as the line that you mentioned is concerned I added it to ensure that visibility toggle is not covered by error icon in confirm password.

Acash512 commented 3 years ago

Resolved merge conflicts, there were some formatting issues

epicadk commented 3 years ago

@isabelcosta you'll probably need to approve this again.

isabelcosta commented 2 years ago

Looks good to me :) Thank you so much @vj-codes for testing this PR 🥳 🙌🏾 Note: Vaishnavi and I noticed there is a little bug where the password mismatch text changes but this was not created through this PR, so an issue to fix this bug will follow up :)