Add toast message when no user with common interests is found using filter

[Yash-Raj-Singh]

Description

Added Toast for the situation when no user with common interests are not found.

Fixes #864

Type of Change:

• Code

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested on my smartphone.

• Device - Samsung M21
• OS - Android 11

Checklist:

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials
• [x] Any dependent changes have been merged

Code/Quality Assurance Only

• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes

Video :

https://user-images.githubusercontent.com/57872757/129070258-7620b66e-7ae7-42f0-8358-e98f632dea8a.mp4

[Yash-Raj-Singh]

@epicadk I have a question, What is the limit of item shown per page by a recyclerview ?

[epicadk]

@epicadk I have a question, What is the limit of item shown per page by a recyclerview ?

Not sure if this was changes but I think the default limit is 20? cc @anitab-org/mentorship-maintainers

[Yash-Raj-Singh]

@epicadk I have a question, What is the limit of item shown per page by a recyclerview ?

Not sure if this was changes but I think the default limit is 20? cc @anitab-org/mentorship-maintainers

I did change it to 100 purposefully, cause otherwise it was searching only in those initial 20 items shown by recyclerview. I tried to extend it to 250 or 500 but figured out that 100 was a limit. Basically in some manner it is helping us to search in a broad data. What do you think? @epicadk

[epicadk]

Please solve the merge conflicts. The rest of it seems good. 👍🏽

[Yash-Raj-Singh]

Please solve the merge conflicts. The rest of it seems good. 👍🏽

@epicadk Can you please tell me how to remove this conflict, cause I didn't understood well what to do here?

[devkapilbansal]

Please solve the merge conflicts. The rest of it seems good. 👍🏽

@epicadk Can you please tell me how to remove this conflict, cause I didn't understood well what to do here?

@Yash-Raj-Singh you need to fetch changes from develop branch of this repository and merge/rebase your branch. Let us know if you need any help

[Yash-Raj-Singh]

Please solve the merge conflicts. The rest of it seems good. 👍🏽

@epicadk Can you please tell me how to remove this conflict, cause I didn't understood well what to do here?

@Yash-Raj-Singh you need to fetch changes from develop branch of this repository and merge/rebase your branch. Let us know if you need any help

Thanks for quick assistance @devkapilbansal. So if I fetch the new updated develop branch and perform the changes there, won't it create a new PR?

[devkapilbansal]

Please solve the merge conflicts. The rest of it seems good. 👍🏽

@epicadk Can you please tell me how to remove this conflict, cause I didn't understood well what to do here?

@Yash-Raj-Singh you need to fetch changes from develop branch of this repository and merge/rebase your branch. Let us know if you need any help

Thanks for quick assistance @devkapilbansal. So if I fetch the new updated develop branch and perform the changes there, won't it create a new PR?

Nah, you need to rebase this branch and push the changes. This is how you should proceed:

# fetch the develop branch
git remote add upstream https://github.com/anitab-org/mentorship-android.git
git fetch upstream develop
# checkout on your branch
git checkout Toast_after_no_common_interest_found
# perform a rebase
git rebase upstream develop
# there will be some conflicts shown in the file mentioned above, i.e. `MembersFragment.kt`. Edit that file manually and do the changes.
# once done add your changes and continue
git add `app/src/main/java/org/systers/mentorship/view/fragments/MembersFragment.kt`
git rebase --continue
# force push your changes
git push -f

Note:- You can use merge instead of rebase too. Both will make the similar changes but they differ in how they work. Also, I will suggest get some hands on experience with git, https://learngitbranching.js.org/

[Yash-Raj-Singh]

Please solve the merge conflicts. The rest of it seems good. 👍🏽

@epicadk Can you please tell me how to remove this conflict, cause I didn't understood well what to do here?

@Yash-Raj-Singh you need to fetch changes from develop branch of this repository and merge/rebase your branch. Let us know if you need any help

Thanks for quick assistance @devkapilbansal. So if I fetch the new updated develop branch and perform the changes there, won't it create a new PR?

Nah, you need to rebase this branch and push the changes. This is how you should proceed:

# fetch the develop branch
git remote add upstream https://github.com/anitab-org/mentorship-android.git
git fetch upstream develop
# checkout on your branch
git checkout Toast_after_no_common_interest_found
# perform a rebase
git rebase upstream develop
# there will be some conflicts shown in the file mentioned above, i.e. `MembersFragment.kt`. Edit that file manually and do the changes.
# once done add your changes and continue
git add `app/src/main/java/org/systers/mentorship/view/fragments/MembersFragment.kt`
git rebase --continue
# force push your changes
git push -f

Note:- You can use merge instead of rebase too. Both will make the similar changes but they differ in how they work. Also, I will suggest get some hands on experience with git, https://learngitbranching.js.org/

@devkapilbansal Thanks, gonna do this asap.

[Yash-Raj-Singh]

@devkapilbansal I guess I messed up something, I am not getting it. And git rebase --continue was not working even after manually editing the file and performing git add . I have forked this repo so there an option to fetch upstream in github, I did that and then tried fixing it. Now even the resolve conflict option is showing something else. Can you check my last commit ?

[Yash-Raj-Singh]

@devkapilbansal @vj-codes Solved the merge conflict. Please have a look. :)

[Yash-Raj-Singh]

@isabelcosta Can you please review the code? Earlier it was having some merge conflicts, now all seems to be good. Thanks :)

[Yash-Raj-Singh]

@devkapilbansal Review needed, conflict has been resolved. Please have a look.

[Yash-Raj-Singh]

@epicadk Done bro 👍🏽 Check this out :)

[Yash-Raj-Singh]

@isabelcosta @epicadk Can you please review this PR, its been a long time? 😅