search

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
167 stars 379 forks source link

Remove Travis and Codacy Badge Table #1156

Closed kulloveth closed 2 years ago

kulloveth commented 2 years ago

Description

Removed travis and codacy badges table

Fixes #1155

Type of Change:

Removed travis and codacy badges table

Code/Quality Assurance Only

How Has This Been Tested?

Checked the ReadMe and the table has been removed

kulloveth commented 2 years ago

@kulloveth thank you for contributing! Could you remove the files unrelated to this issue from git? These would be any file that is not README.

I have removed them

kulloveth commented 2 years ago

Thank you for addressing the comments! Can you please revert the changes done on .gitignore and buildSrc folders, they show up as deleted on "Files Changed" tab on this pull request.

done

kulloveth commented 2 years ago

seems like I have to also add gradle-wrapper.properties back, the workflow seems to failing because of it @isabelcosta

gaurivn commented 2 years ago

seems like I have to also add gradle-wrapper.properties back, the workflow seems to failing because of it @isabelcosta

@kulloveth, how is it going, pls update

kulloveth commented 2 years ago

hey @gaurivn yeah Isabel requested I remove files that were not related to the changes but then I see the build is failing because the gradle wrapper is missing. was asking if I should add it back

kulloveth commented 2 years ago

Thank you for contributing @kulloveth 🙌🏾

Missed that one, thank you

vj-codes commented 2 years ago

Adding label ready to merge since it's a documentation change

isabelcosta commented 2 years ago

@kulloveth congratulations on your first PR to the repository! LGTM🎉 Quick tip : create a new separate branch on your fork repo and then commit the changes when contributing in the future. It is always a good open source practice and mentioned in the community guidelines too:)

Great tip @vj-codes ! 🤗