Closed vj-codes closed 2 years ago
@vj-codes I suggest you to use proper commit message guidelines.
New contributors generally try to look how maintainers and team members work and follow the same procedure.
@devkapilbansal apologies, if you check the first 2 commit messages, they are proper as per the guidelines, then the build was still failing so I was testing locally and the messages were some dummy text I put without realizing it will get reflected here 🤦
@devkapilbansal I squashed them,but now there are some conflicts again and I struggle with that which is why the previous PR was closed :/
@isabelcosta it would be great if you could review this as well, thankss in advance:)
@isabelcosta it would be great if you could create the hacktoberfest accepted label.
@isabelcosta it would be great if you could create the hacktoberfest accepted label.
I don't think it's needed as the topic is already added, the condition is either the label or maintainer approval right?
@isabelcosta it would be great if you could create the hacktoberfest accepted label.
I don't think it's needed as the topic is already added, the condition is either the label or maintainer approval right?
Not sure maybe you could check.
@vj-codes @epicadk added the label now. But if you also could get this tested it would be great, so we could move this forward too 🤗
Amazing! This will be a big bang PR, it will create merge conflicts on some PRs 🙈 @anitab-org/mentorship-maintainers should we merge this soon and get this done, or prioritize couple PRs before? I am fine with either, maybe this is not a question at all 🤔
Thank you so so much for testing this @Yash-Raj-Singh 💯 🎉
Amazing! This will be a big bang PR, it will create merge conflicts on some PRs 🙈 @anitab-org/mentorship-maintainers should we merge this soon and get this done, or prioritize couple PRs before? I am fine with either, maybe this is not a question at all 🤔
We should merge it. Other contributors can always fix conflicts.
Description
As the organization name has been changed from systers to anitab, the code has been synced to reflect the same
Fixes #1132
Type of Change:
How Has This Been Tested?
Locally
Checklist:
Code/Quality Assurance Only