Fix: Added toast message for "no skills' filter

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.

https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk

GNU General Public License v3.0

167 stars 379 forks source link

Fix: Added toast message for "no skills' filter #1173

Closed SubhraPriyadarshinee closed 2 years ago

SubhraPriyadarshinee commented 2 years ago

Description

Found similar code for "location filter"
Copy pasted the same code below that

Fixes #866

Type of Change:

Code

How Has This Been Tested?

Open app -> Go to members page -> open filter -> type anything on "skills" box that has zero results -> now it will show a toast message

Checklist:

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-review of my own code or materials

vj-codes commented 2 years ago

@SubhraPriyadarshinee please update the PR description to Fixes #866 so that this PR gets linked with the issue

SubhraPriyadarshinee commented 2 years ago

Hello, Can you please delete the last pull request for fix #879 . I was trying to make a PR but it accidentally got merged with this one.

SubhraPriyadarshinee commented 2 years ago

Hello, Can you please delete the last pull request for fix #879 . I was trying to make a PR but it accidentally got merged with this one.

@vj-codes @epicadk

vj-codes commented 2 years ago

@SubhraPriyadarshinee I am not sure what do you mean by "delete PR", please elaborate:)

SubhraPriyadarshinee commented 2 years ago

@SubhraPriyadarshinee I am not sure what do you mean by "delete PR", please elaborate:) Actually, I was making a different PR for a different issue but somehow it got merged with this one and is showing these errors.

vj-codes commented 2 years ago

@SubhraPriyadarshinee can you try reverting the last commit?

vj-codes commented 2 years ago

Closing this PR due to inactivity. Thank you for your contribution @SubhraPriyadarshinee :)