feat: New Window for Searching Members

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.

https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk

GNU General Public License v3.0

167 stars 379 forks source link

feat: New Window for Searching Members #1174

Open bosankus opened 2 years ago

bosankus commented 2 years ago

Description

Created a separate fragment for searching members i.e SearchMembersFragment. This solves the below mentioned issue, and is implemented as per the discussion on issue #719.

Fixes #732

Type of Change:

Code
User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works - Espresso testing added but needs to be reviewed
[x] New and existing unit tests pass locally with my changes

bosankus commented 2 years ago

@isabelcosta @epicadk facing one issue in this PR. That is the added espresso testing. Though the feature works fine. It will be helpful if any of you can help me to review the testing part. Also I will be creating a new issue for the back press issue which is getting faced in this new screen. 'Cancel' button removes the fragment and works smooth. Kindly share any ideas regarding this.

epicadk commented 2 years ago

@isabelcosta @epicadk facing one issue in this PR. That is the added espresso testing. Though the feature works fine. It will be helpful if any of you can help me to review the testing part. Also I will be creating a new issue for the back press issue which is getting faced in this new screen. 'Cancel' button removes the fragment and works smooth. Kindly share any ideas regarding this.

Yeah for some reason I couldn't get the tests to work either. @isabelcosta do you think we could create an issue for this and perhaps only manually test it now?

bosankus commented 2 years ago

@isabelcosta can you check kindly?

vj-codes commented 2 years ago

@bosankus thank you for your inputs, do create the issue if you have time as you have got a better understanding of it, if not that's alright as well. We can proceed with manual testing of the feature!

bosankus commented 2 years ago

@vj-codes Sure, I will create the issue.

bosankus commented 2 years ago

This feature will be improved due to implementation of paging3 in MembersFragment from issue #1166. Closing this issue due to duplicate.