anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
167 stars 379 forks source link

Bug : the application is not supposed to crash because of a server error #1175

Open yveskalume opened 2 years ago

yveskalume commented 2 years ago

Describe the bug

an internal error makes the application crash when a new user tries to signup

To Reproduce

Steps to reproduce the behavior:

  1. Go to Sign Up
  2. Complete the informations
  3. Click on Sign Up button
  4. See error the sign up screen will close without message. In the log of android studio you can see "HTTP 500 Internal Server Error".

Expected behavior

an error that something is wrong should be displayed without the application crashing

Smartphone (please complete the following information):

Additional context

this can be fixed by adding a try catch in the AuthDataManager (I've already tested and it worked)

epicadk commented 2 years ago

Can someone validate this? @anitab-org/mentorship-testers

Also if this is the case why doesn't this work? https://github.com/anitab-org/mentorship-android/blob/c06975106b5d08eab09e8e0afc9c48ac92bd49e9/app/src/main/java/org/anitab/mentorship/viewmodels/SignUpViewModel.kt#L29-L35

yveskalume commented 2 years ago

@epicadk although there is a try catch in the viewmodel, you have to add another one in the AuthManager and throw an exception in the catch scope

yveskalume commented 2 years ago

Can i open a PR ?

epicadk commented 2 years ago

Sure

vj-codes commented 2 years ago

Can someone validate this? @anitab-org/mentorship-testers

Also if this is the case why doesn't this work?

https://github.com/anitab-org/mentorship-android/blob/c06975106b5d08eab09e8e0afc9c48ac92bd49e9/app/src/main/java/org/anitab/mentorship/viewmodels/SignUpViewModel.kt#L29-L35

Yes the issue is valid, @YvesKalume thank you so much for reporting it :)

rishujam commented 1 year ago

Hey, Is this project still being maintained?

vj-codes commented 1 year ago

Hey yes being maintained

OwaisKhatri commented 1 year ago

Do I need to setup the backend also to build & run this Android app?

vj-codes commented 1 year ago

Do I need to setup the backend also to build & run this Android app?

Hey no you can download the apk directly

OwaisKhatri commented 1 year ago

I build this project and run the app from Android Studio. But, the app gets crashed on sign up.