anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
167 stars 379 forks source link

1166: Migration to Paging3 for MembersFragment #1221

Open bosankus opened 1 year ago

bosankus commented 1 year ago

Description

Screenshot 2022-10-04 at 10 22 29 AM

Fixes #1166

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

Checklist:

Code/Quality Assurance Only

bosankus commented 1 year ago

The existing filter feature on member list was not working, and after implementinig paging3 , it is found that there is a issue with sorting and filtering the list. Refer here : https://issuetracker.google.com/issues/175430431. I am trying work around for this filtering feature at this moment, which will solve this issue.

bosankus commented 1 year ago

@vj-codes @isabelcosta Two points I would like to raise: Please review this and this PR kindly.

Please share feedback on this

bosankus commented 1 year ago

@vj-codes A check is failing, however I am unable to understand what change to do. It's regarding collision of two kotlin-stdlib versions, but i removed the dependency since its deprecated. Still the same.

bosankus commented 1 year ago

Hi @isabelcosta @vj-codes Can you please review ?