search

anitab-org / mentorship-android

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.
https://github.com/anitab-org/mentorship-android/raw/apk/app-debug.apk
GNU General Public License v3.0
165 stars 379 forks source link

Alterable notes #544

Open daksha-aeer opened 4 years ago

daksha-aeer commented 4 years ago

Is your feature request related to a problem? Please describe. When a mentee/mentor sends a request, they can send notes. But these notes can’t be altered in the future. So if someone wants to make a change to what they sent as it may have been incomplete or might have had typos, they can’t and that can get frustrating.

Describe the solution you'd like My suggestion is that the notes should be alterable. So that the mentor/mentee can make any changes they want.

Describe alternatives you've considered An alternative solution is to not have the notes sent while sending the request but after the relation has started. This should also be alterable. Another suggestion is that both the mentor and mentee can send the notes after the relation has started. The mentor can give a few guidance points and also advice on some of the tasks. IMG-20200112-WA0007

devanshi7799 commented 4 years ago

I would like to work on this

Priyansh-Kedia commented 4 years ago

May I work on this?

Sunil16202 commented 4 years ago

Please assign this task to me, till now I didn't get any assigned task.

aditmehta9 commented 4 years ago

@Sunil16202 do you want to work on this issue?

pallavisavant commented 4 years ago

could you pls assign this to me ,i would like to work on this thanks

rpattath commented 4 years ago

Hi @pallavisavant any update on a PR for this issue? Let me know if you need any help.

pallavisavant commented 4 years ago

Hi @pallavisavant any update on a PR for this issue? Let me know if you need any help.

i am un assigning myself from this particular issue..i would like to work on others....sorry for the inconvenience ....feel free to assign it to anyone else...Thanks.

justdvnsh commented 4 years ago

@rpattath @anna4j Can I work on this issue ?

anna4j commented 4 years ago

Sure :)

justdvnsh commented 4 years ago

@rpattath @anna4j I think this is a backend issue. I tried different solutions but none of them are working !! It would be very easy if there was an API endpoint for altering the notes. One thing which can be done is that to alter notes we can cancel the current relation and then re send the request and then make the request accepted on both the mentor and mentees end programatically. But it would require a lot of work everytime when we alter the notes. What are your views on this @iofall @rpattath ?

rpattath commented 4 years ago

@rpattath @anna4j I think this is a backend issue. I tried different solutions but none of them are working !! It would be very easy if there was an API endpoint for altering the notes. One thing which can be done is that to alter notes we can cancel the current relation and then re send the request and then make the request accepted on both the mentor and mentees end programatically. But it would require a lot of work everytime when we alter the notes. What are your views on this @iofall @rpattath ?

@isabelcosta what do you think about the above?

isabelcosta commented 4 years ago

The notes to become modifiable would have to include work on the backend. Also, notes are supposed to be something both mentor and mentee agree on. So I can think of making it modifiable before it gets accepted, so whoever send it can edit and improve it over time.

So I would say this needs better discussion, as it is a product decision that should be documented. cc @rpattath @anna4j @iofall

vj-codes commented 4 years ago

Keeping the issue on hold @isabelcosta and Unassigning @justdvnsh for now