Open garimasingh128 opened 4 years ago
Can you assign this issue to me for OSH ?
Can you assign this issue to me for OSH ?
Yes of course. OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution and please tag project managers to claim issue.
I could also work on it, so kindly assign it to me, if in case @blackcrabb is unable to take up this issue.
@garimasingh128 i would like to work on this issue
Can you assign this issue to me for OSH ?
Assigned.
@aditmehta9 @blackcrabb is already assigned #795 first so unassigning for now. @blackcrabb Please work on one issue at a time and once done claim another .Thanks!
@aditmehta9 @blackcrabb is already assigned #795 first so unassigning for now. @blackcrabb Please work on one issue at a time and once done claim another .Thanks!
Thanks! I didn't noticied.
I could also work on it, so kindly assign it to me, if in case @blackcrabb is unable to take up this issue.
Assigning you @prayutsu
I could also work on it, so kindly assign it to me, if in case @blackcrabb is unable to take up this issue.
Assigning you @prayutsu
he's already assigned to another issue
@garimasingh128 @aditmehta9 @anna4j i would like to take up this issue :-) Can u pls tell what all data needs to be saved for offline viewing ?
@anna4j you wanna add something?
- His own profile details
- Requests
@anna4j you wanna add something?
@garimasingh128 ok, so shall i start working on the issue ?
- His own profile details
- Requests
@anna4j you wanna add something?
Sorry I missed it earlier. User should also be able to see their tasks offline
@anna4j @garimasingh128 hey idk how but this issue showed up in my notifications .There was already a similar issue #714 and a PR #718 was created but after very long discussion both PR and issue was put up on hold by Isabel. Just letting you guys know, the status of this one (approved/hold) is upto you .Thanks!
For now, I think let's wait how @CodeChamp-SS implements the process and have a look at his PR. Then we can see whether it should be merged or not. What's say @vj-codes ?
shall i make use of coroutines in room ? (i think it would be better if it's used)
@garimasingh128 as i am adding room dependencies to the app, so shall i also update other dependencies version and gradle version for the app ?
@CodeChamp-SS Yeah you can but make sure nothing else breaks and keep testing the other components as well.
@CodeChamp-SS Yeah you can but make sure nothing else breaks and keep testing the other components as well. ok
shall i make use of coroutines in room ? (i think it would be better if it's used)
@garimasingh128 nd what abt this ?
I have never implemented Coroutines myself so if you have used them earlier and pretty confident about it, you can go ahead. I will do a little research about them and get back to you in a day or two.
I have never implemented Coroutines myself so if you have used them earlier and pretty confident about it, you can go ahead. I will do a little research about them and get back to you in a day or two.
ya i've used it earlier but you can take your time and tell me tell if i should use it, till then i'll try to implement coroutines with room in the app
@garimasingh128 @anna4j fab for adding tasks is hidden under the bottom nav view, is this a valid issue ? If yes, then i can also fix this issue
@garimasingh128 should we let him open an issue for this and then work on it? Or work on it under this issue itself
@CodeChamp-SS try scrolling down the page and then the button is visible There was a issue #744 about the and PR #745 which is merged now cc: @anna4j
@CodeChamp-SS try scrolling down the page and then the button is visible There was a issue #744 about the and PR #745 which is merged now cc: @anna4j
no @vj-codes not visible to me
@anna4j @garimasingh128 can either of you please confirm whether you can see the fab or not ?
@CodeChamp-SS which device? This bug is strange, just checked now on mine and it's visible
@CodeChamp-SS which device? This bug is strange, just checked now on mine and it's visible
i just checked out the pr, the changes made their in the fragment_mentorship_tasks.xml are not reflecting in my cloned repo
if the issue has already been fixed, then it's fine
@CodeChamp-SS your fork is 4 commits behind the develop branch that inclues the task button commit too , if you sync your fork it'll work ! Or uninstall current apk and download apk from this main repo and not your clone on your device
@CodeChamp-SS your fork is 4 commits behind the develop branch that inclues the task button commit too , if you sync your fork it'll work ! Or uninstall current apk and download apk from this main repo and not your clone on your device
ya i'm syncing it now
@anna4j @garimasingh128 i've implemented saving profile for offline view, but while implementing saving tasks and requests i realised that a huge amount of code base has to be changes in order to achieve so. So what shall i do ? Shall i make a pr with only feature of offline viewing of profile or what ?
I think too much change in code would be too much to do for a single issue. We can store profile data offline for now and create separate issues for saving tasks and requests. What's say @anna4j @vj-codes ?
@garimasingh128 @CodeChamp-SS agreed for now just profile view is good , do update the issue accordingly though:)
i've implemented the offline viewing of data in the profile fragment, i.e, the profile details. Is it fine ?
i've implemented the offline viewing of data in the profile fragment, i.e, the profile details. Is it fine ?
shall i make the pr with these changes ?
Ya go ahead
If this issue is still open , Can i work on this ?
If this issue is still open , Can i work on this ?
Sorry a pr has already been created. Removing status available
Description
As an user of the app, sometimes I may need to check my profile or requests but network connection may not be available. So my profile data, requests and such other information should be stored locally in my phone. For example in Whatsapp, you can check the chats even if you're offline. In the same way, I should be able to check my stats on the app without going online. We can use room database for storing the data locally.
Acceptance Criteria
Update [Required]
Definition of Done
Estimation
2-4 hours depending on fluency with the backend and database.