Open vj-codes opened 3 years ago
Merging #1077 (d0ed903) into develop (8924616) will decrease coverage by
0.23%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #1077 +/- ##
===========================================
- Coverage 94.94% 94.71% -0.24%
===========================================
Files 38 39 +1
Lines 2058 2063 +5
===========================================
Hits 1954 1954
- Misses 104 109 +5
Impacted Files | Coverage Ξ | |
---|---|---|
scripts.py | 0.00% <0.00%> (ΓΈ) |
@isabelcosta hey I have resolved the conflicts from the previous PR , as expected all commits have been included in this PR, and about poetry add psycopg2
I need to install poetry first π but all that's need to be done is to use the command and commit right?
@isabelcosta @epicadk I've added psycopg2 and made the requested changes ,
poetry: command not found
this error is shown when I updated gh actions to run tests with poetry so I reverted the change
After using poetry locally here are my inputs-
1) poetry run start and poetry run tests works as expected
2) poetry shell probably creates a virtual env but the word venv
does not appear like it used to before so how to confirm the activation?
3) And what are those codecov warnings about on github?
The label was still on needs review due to which I forgot there were changes requested, will update them and resolve the conflict in a day!
Ok so to test this, we should:
Goal: We need to check that all the necessary instructions on README are enough to set this successfully as a newcomer would.
cc @anitab-org/mentorship-maintainers
Ok so to test this, we should:
- Clone the repo
- Set it up from scratch like a newcomer
- Check if the setup was successful
Goal: We need to check that all the necessary instructions on README are enough to set this successfully as a newcomer would.
cc @anitab-org/mentorship-maintainers
Hi, I setup the repository locally and this are the problems I found.
@devkapilbansal what PATH are you speaking about and which OS?
@devkapilbansal what PATH are you speaking about and which OS?
@vj-codes path to Poetry in environment. I tried it on Ubuntu 20.04
@devkapilbansal in my case it did get set automatically on windows though I agree with moving the commands to keep them in the same place π
@devkapilbansal I've moved the commands and about the path we can't do anything as it's a part of poetry docs and not here @gaurivn can you test it please and share if you also have the same issue? Or maybe we can add something like if the commands don't work after installing try setting up the path manually, what say?
@vj-codes runnimg this command do the needful for me
export PATH=$HOME/.poetry/bin:$PATH
We can add this if in case poetry doesn't work after installation. What's say?
Description
This PR is a continuation of #914 which uses Poetry has the default dependency management tool
Fixes #691
Type of Change:
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only