Closed vj-codes closed 3 years ago
Lint check failing. I know you haven't made any changes but can you still run black?
@epicadk yup see this comment it's passing locally for me but actions is failing
Merging #1079 (f865234) into develop (9571c86) will increase coverage by
0.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #1079 +/- ##
===========================================
+ Coverage 92.71% 92.90% +0.18%
===========================================
Files 38 38
Lines 2019 2073 +54
===========================================
+ Hits 1872 1926 +54
Misses 147 147
Impacted Files | Coverage Δ | |
---|---|---|
app/database/models/user.py | 98.57% <ø> (ø) |
|
app/api/jwt_extension.py | 100.00% <0.00%> (ø) |
|
app/api/resources/task.py | 100.00% <0.00%> (ø) |
|
app/api/dao/task_comment.py | 100.00% <0.00%> (ø) |
|
app/api/resources/task_comment.py | 100.00% <0.00%> (ø) |
|
app/api/models/mentorship_relation.py | 100.00% <0.00%> (ø) |
|
app/api/dao/user.py | 85.82% <0.00%> (+0.05%) |
:arrow_up: |
app/api/dao/admin.py | 96.00% <0.00%> (+0.08%) |
:arrow_up: |
run.py | 96.15% <0.00%> (+0.15%) |
:arrow_up: |
app/api/resources/mentorship_relation.py | 96.51% <0.00%> (+0.21%) |
:arrow_up: |
... and 4 more |
@epicadk the tests are still running twice , should the changes be done here as the same file is being updated?
Ready to merge after one more review.
Description
Improved github actions to use a matrix
Fixes #1078
Type of Change:
Checklist:
Code/Quality Assurance Only