anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.
https://mentorship-backend-temp.herokuapp.com/
GNU General Public License v3.0
196 stars 449 forks source link

Change task comment api #1126

Open RiddhiAthreya opened 3 years ago

RiddhiAthreya commented 3 years ago

Description

The response has been changed to : Screenshot (178)

Fixes #1110 #685

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

Has been tested in local environment by accessing the endpoint. An example : Screenshot (177)

Checklist:

Code/Quality Assurance Only

welcome[bot] commented 3 years ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats 🎉 for opening your first PR on this project.✨ Please ensure your Pull Request meets the Commit Message Style Guide. We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities. Hope you have a great time here :)

RiddhiAthreya commented 3 years ago

@epicadk I've made a PR , please let me know if any changes are required

epicadk commented 3 years ago

Also link #685

epicadk commented 3 years ago

If in the future we want to have a mentor groups then I think this would not be easily extendable to that.

RiddhiAthreya commented 3 years ago

@epicadk Oh I see. Then should I include the corresponding user's details in each comment object?

RiddhiAthreya commented 3 years ago

@epicadk I've made the changes in the latest commit. Let me know if any changes are required