Open RiddhiAthreya opened 3 years ago
You'll also need to add migrations
@epicadk can you please tell me how to add that?
@epicadk can you please tell me how to add that?
I believe @mtreacy002 was going to create a doc for this?
You'll also need to add migrations
@epicadk , IMO @RiddhiAthreya doesn't need to write a migration script here since the changes applies to dao object of Task and the logic used inside Task db model. The Task db model itself doesn't get affected with the changes here. I tried running flask db migrate and got the response below.
Let me know if you have a different view on this 😉
@mtreacy002 true , only the task json object has changed, but the task table remains the same :smiley:
@RiddhiAthreya any updates?
Description
Task has got new property requires_approval: [bool]. If it's set to True during creation, task becomes "restricted" - i.e only mentor can mark it as done/completed. When mentee tries to mark it as done, he get's 401 Unauthorized.
Fixes #278
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
When a mentee tries to update a task which has
requires_approval
set to Truecreating a task with
required_approval
set to TrueWhen mentor tries to update a task which has requires_approval set to True
Checklist:
Code/Quality Assurance Only