anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.
https://mentorship-backend-temp.herokuapp.com/
GNU General Public License v3.0
196 stars 449 forks source link

Add missing tests in Mentorship Relation #1136

Closed diananova closed 3 years ago

diananova commented 3 years ago

Description

Add missing tests for Mentorship relation. Fixes #990

New Tests

Mentioned in the issue:

Other Tests suggestions :

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

python -m unittest tests/mentorship_relation/test_dao_creation.py

Checklist:

Code/Quality Assurance Only

codecov[bot] commented 3 years ago

Codecov Report

Merging #1136 (abe18e5) into develop (4193589) will increase coverage by 0.33%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1136      +/-   ##
===========================================
+ Coverage    92.91%   93.25%   +0.33%     
===========================================
  Files           38       38              
  Lines         2062     2062              
===========================================
+ Hits          1916     1923       +7     
+ Misses         146      139       -7     
Impacted Files Coverage Δ
app/api/dao/mentorship_relation.py 100.00% <0.00%> (+3.95%) :arrow_up:
diananova commented 3 years ago

Ready for review!

epicadk commented 3 years ago

Thanks looks good : )

isabelcosta commented 3 years ago

will merge since tests are passing and this is not a production code change