anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.
https://mentorship-backend-temp.herokuapp.com/
GNU General Public License v3.0
196 stars 449 forks source link

Extend `password_hash` limit from User data model #1137

Open isabelcosta opened 3 years ago

isabelcosta commented 3 years ago

Description

As a developer, I need to remove the limit for password_hash, so that I can fix the registration endpoint, that is erroring 500 INTERNAL SERVER ERROR, because of the limit being reached.

This relates to fixing #1109

A comment that may help: https://github.com/anitab-org/mentorship-backend/issues/1109#issuecomment-886053853

Mocks

print from swagger with the error

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

4h

isabelcosta commented 3 years ago

I would suggest setting a postgres SQL database, which is what we are using in the deployed server. I am using https://elephantsql.com/ for it (so the contributor can too). Make sure to have this working with a database with the current state of the models, and only after you create and run the migration to alter/modify the column to not have a limit or have a bigger limit.

If any doubts you can ping me or @anitab-org/mentorship-maintainers and on Zulip => https://anitab-org.zulipchat.com/ 🤗

epicadk commented 3 years ago

https://github.com/anitab-org/mentorship-backend/issues/1109#issuecomment-886228556

isabelcosta commented 3 years ago

Thank you for your points @epicadk on #1109 I just changed the title ;)

mridubhatnagar commented 3 years ago

@isabelcosta I am a first-timer. I am interested in solving this issue, can you please assign it to me. :)

vj-codes commented 3 years ago

Assigning you @mridubhatnagar Happy coding! And welcome to the community:)

mridubhatnagar commented 3 years ago

@vj-codes @isabelcosta I have set up the project on my local system. Just wanted to understand how can I set up a database for the project?

epicadk commented 3 years ago

@vj-codes @isabelcosta I have set up the project on my local system. Just wanted to understand how can I set up a database for the project?

It should automatically create a sqllite database.

mridubhatnagar commented 3 years ago

@vj-codes @isabelcosta I have set up the project on my local system. Just wanted to understand how can I set up a database for the project?

It should automatically create a sqllite database.

On my local system when I run the server. I am getting an error

sqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:None 127.0.0.1 - - [23/Aug/2021 18:42:47] "GET /favicon.ico HTTP/1.1" 500 -

One of the possible reason the above errors comes is due to spelling mistake in the database name sqllite instead sqlite. I did cross check config.py to make sure spellings are correct. I could not find any mistake in file though. Not sure what could be other possible reason for the error.

epicadk commented 3 years ago

Are you using docker or venv?

mridubhatnagar commented 3 years ago

Are you using docker or venv?

venv

vj-codes commented 3 years ago

@mridubhatnagar I have linked the possible fixes on zulip:)

mridubhatnagar commented 3 years ago

@vj-codes responded to you on zulip. :)